✗ Fi.CI.CHECKPATCH: warning for Hexdump enhancements

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: Hexdump enhancements
URL   : https://patchwork.freedesktop.org/series/59296/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4911981b19d1 lib/hexdump.c: Allow 64 bytes per line
49ccc448ceaa lib/hexdump.c: Optionally suppress lines of filler bytes
-:50: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#50: FILE: include/linux/printk.h:499:
+extern void print_hex_dump_ext(const char *level, const char *prefix_str,

-:83: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#83: FILE: include/linux/printk.h:529:
+	print_hex_dump_ext(level, prefix_str, prefix_type, rowsize, groupsize,
+			buf, len, ascii ? HEXDUMP_ASCII : 0);

-:86: CHECK:LINE_SPACING: Please don't use multiple blank lines
#86: FILE: include/linux/printk.h:532:
+
+

-:217: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#217: FILE: lib/hexdump.c:338:
+	print_hex_dump_ext(KERN_DEBUG, prefix_str, prefix_type, 16, 1,
+		       buf, len, HEXDUMP_ASCII);

total: 0 errors, 0 warnings, 4 checks, 185 lines checked
560d296fb9d8 lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags
-:282: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#282: FILE: lib/test_hexdump.c:175:
+	r = hex_dump_to_buffer(data_b, len, rs, gs, buf, buflen,
+			ascii ? HEXDUMP_ASCII : 0);

total: 0 errors, 0 warnings, 1 checks, 195 lines checked
3470b899c699 lib/hexdump.c: Allow multiple groups to be separated by lines '|'
-:125: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#125: FILE: lib/hexdump.c:232:
+		if (line_chars && ((j + 1) < len) &&
+				((j + 1) % line_chars == 0)) {

total: 0 errors, 0 warnings, 1 checks, 124 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx