From: Imre Deak <imre.deak@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Suppress spurious combo PHY B warning
Date: Fri, 12 Apr 2019 11:29:17 +0300 [thread overview]
Message-ID: <20190412082917.GA14650@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20190411143349.17934-1-ville.syrjala@linux.intel.com>
On Thu, Apr 11, 2019 at 05:33:49PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On ICL the DMC doesn't reinit combo PHY B so we should not warn
> about its state being bogus during the display core uninit.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Yep, and we'll reinit it manually before using it:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_combo_phy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
> index 3d0271cebf99..2bf4359d7e41 100644
> --- a/drivers/gpu/drm/i915/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/intel_combo_phy.c
> @@ -239,7 +239,8 @@ void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
> for_each_combo_port_reverse(dev_priv, port) {
> u32 val;
>
> - if (!icl_combo_phy_verify_state(dev_priv, port))
> + if (port == PORT_A &&
> + !icl_combo_phy_verify_state(dev_priv, port))
> DRM_WARN("Port %c combo PHY HW state changed unexpectedly\n",
> port_name(port));
>
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-12 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 14:33 [PATCH] drm/i915: Suppress spurious combo PHY B warning Ville Syrjala
2019-04-11 22:54 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-12 8:29 ` Imre Deak [this message]
2019-04-12 13:37 ` [PATCH] " Ville Syrjälä
2019-04-12 11:41 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412082917.GA14650@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox