From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Swati Sharma <swati2.sharma@intel.com>
Cc: jani.nikula@intel.com, daniel.vetter@ffwll.ch,
intel-gfx@lists.freedesktop.org, ankit.k.nautiyal@intel.com,
kbuild-all@01.org
Subject: Re: [Intel-gfx] [PATCH 11/11] [v3] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values
Date: Tue, 16 Apr 2019 14:42:02 +0300 [thread overview]
Message-ID: <20190416114202.GA27693@kadam> (raw)
In-Reply-To: <1555324408-26054-12-git-send-email-swati2.sharma@intel.com>
Hi Swati,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-adding-state-checker-for-gamma-lut-values/20190416-021708
base: git://anongit.freedesktop.org/drm-intel for-linux-next
New smatch warnings:
drivers/gpu/drm/i915/intel_color.c:1519 intel_compare_color_lut() warn: variable dereferenced before check 'blob1' (see line 1514)
drivers/gpu/drm/i915/intel_color.c:1519 intel_compare_color_lut() warn: variable dereferenced before check 'blob2' (see line 1515)
# https://github.com/0day-ci/linux/commit/14a61c5a3c40291ad8779909b5fdc261aad53df3
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 14a61c5a3c40291ad8779909b5fdc261aad53df3
vim +/blob1 +1519 drivers/gpu/drm/i915/intel_color.c
14a61c5a Swati Sharma 2019-04-15 1510 bool intel_compare_color_lut(struct drm_property_blob *blob1,
14a61c5a Swati Sharma 2019-04-15 1511 struct drm_property_blob *blob2,
14a61c5a Swati Sharma 2019-04-15 1512 u32 gamma_mode)
14a61c5a Swati Sharma 2019-04-15 1513 {
14a61c5a Swati Sharma 2019-04-15 @1514 struct drm_color_lut *sw_lut = blob1->data;
^^^^^^^^^^^
14a61c5a Swati Sharma 2019-04-15 @1515 struct drm_color_lut *hw_lut = blob2->data;
^^^^^^^^^^^
14a61c5a Swati Sharma 2019-04-15 1516 int sw_lut_size, hw_lut_size, i;
14a61c5a Swati Sharma 2019-04-15 1517 u32 bit_precision, err;
14a61c5a Swati Sharma 2019-04-15 1518
14a61c5a Swati Sharma 2019-04-15 @1519 if (!blob1 || !blob2)
^^^^^ ^^^^^^
14a61c5a Swati Sharma 2019-04-15 1520 return false;
14a61c5a Swati Sharma 2019-04-15 1521
14a61c5a Swati Sharma 2019-04-15 1522 switch(gamma_mode) {
14a61c5a Swati Sharma 2019-04-15 1523 case GAMMA_MODE_MODE_8BIT:
14a61c5a Swati Sharma 2019-04-15 1524 bit_precision = 8;
14a61c5a Swati Sharma 2019-04-15 1525 break;
next prev parent reply other threads:[~2019-04-16 11:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 10:33 [PATCH 00/11] drm/i915: adding state checker for gamma lut values Swati Sharma
2019-04-15 10:33 ` [PATCH 01/11] [v3] drm/i915: Introduce vfunc intel_get_color_config to create hw lut Swati Sharma
2019-04-16 9:15 ` Jani Nikula
2019-04-15 10:33 ` [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config() Swati Sharma
2019-04-16 10:42 ` Jani Nikula
2019-04-16 10:45 ` Jani Nikula
2019-04-15 10:33 ` [PATCH 03/11] [v2] drm/i915: Extract cherryview_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 04/11] [v2] drm/i915: Extract i965_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 05/11] [v2] drm/i915: Extract icl_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 06/11] [v2] drm/i915: Extract glk_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 07/11] [v2] drm/i915: Extract bdw_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 08/11] [v2] drm/i915: Extract ivb_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 09/11] [v2] drm/i915: Extract ilk_get_color_config() Swati Sharma
2019-04-15 10:33 ` [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config() Swati Sharma
2019-04-16 9:17 ` Jani Nikula
2019-04-15 10:33 ` [PATCH 11/11] [v3] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values Swati Sharma
2019-04-16 9:29 ` Jani Nikula
2019-04-16 11:42 ` Dan Carpenter [this message]
2019-04-15 10:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev4) Patchwork
2019-04-15 11:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-15 11:13 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416114202.GA27693@kadam \
--to=dan.carpenter@oracle.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox