From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] dma-buf: Remove unused sync_dump()
Date: Tue, 23 Apr 2019 10:21:16 +0200 [thread overview]
Message-ID: <20190423082116.GC30926@phenom.ffwll.local> (raw)
In-Reply-To: <20190419181904.6199-1-chris@chris-wilson.co.uk>
On Fri, Apr 19, 2019 at 07:19:04PM +0100, Chris Wilson wrote:
> sync_dump() is an unused, unexported, function that adds 64k to the
> kernel image and doesn't even provide locking around the global array it
> uses.
>
> add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-65734 (-65734)
> Function old new delta
> sync_dump 198 - -198
> sync_dump_buf 65536 - -65536
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Gustavo Padovan <gustavo@padovan.org>
> ---
> drivers/dma-buf/sync_debug.c | 26 --------------------------
> drivers/dma-buf/sync_debug.h | 1 -
> 2 files changed, 27 deletions(-)
>
> diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c
> index c0abf37df88b..434a66518e0d 100644
> --- a/drivers/dma-buf/sync_debug.c
> +++ b/drivers/dma-buf/sync_debug.c
> @@ -197,29 +197,3 @@ static __init int sync_debugfs_init(void)
> return 0;
> }
> late_initcall(sync_debugfs_init);
> -
> -#define DUMP_CHUNK 256
> -static char sync_dump_buf[64 * 1024];
> -void sync_dump(void)
> -{
> - struct seq_file s = {
> - .buf = sync_dump_buf,
> - .size = sizeof(sync_dump_buf) - 1,
> - };
> - int i;
> -
> - sync_info_debugfs_show(&s, NULL);
> -
> - for (i = 0; i < s.count; i += DUMP_CHUNK) {
> - if ((s.count - i) > DUMP_CHUNK) {
> - char c = s.buf[i + DUMP_CHUNK];
> -
> - s.buf[i + DUMP_CHUNK] = 0;
> - pr_cont("%s", s.buf + i);
> - s.buf[i + DUMP_CHUNK] = c;
> - } else {
> - s.buf[s.count] = 0;
> - pr_cont("%s", s.buf + i);
> - }
> - }
> -}
Oh dear, good riddance!
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h
> index 05e33f937ad0..6176e52ba2d7 100644
> --- a/drivers/dma-buf/sync_debug.h
> +++ b/drivers/dma-buf/sync_debug.h
> @@ -68,6 +68,5 @@ void sync_timeline_debug_add(struct sync_timeline *obj);
> void sync_timeline_debug_remove(struct sync_timeline *obj);
> void sync_file_debug_add(struct sync_file *fence);
> void sync_file_debug_remove(struct sync_file *fence);
> -void sync_dump(void);
>
> #endif /* _LINUX_SYNC_H */
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-23 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 18:19 [PATCH] dma-buf: Remove unused sync_dump() Chris Wilson
2019-04-19 18:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-04-23 8:21 ` Daniel Vetter [this message]
2019-04-23 8:42 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423082116.GC30926@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox