From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/7] drm/i915: Move pm_imr and pm_ier to intel_irc.
Date: Thu, 25 Apr 2019 15:55:28 -0700 [thread overview]
Message-ID: <20190425225528.GQ588@intel.com> (raw)
In-Reply-To: <155623059367.7476.17174153737530019257@skylake-alporthouse-com>
On Thu, Apr 25, 2019 at 11:16:33PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-04-25 22:50:37)
> > No functional change. But by making those bits together
> > we will be able to convert many functions to pass
> > intel_irq instead of i915_private or uncore.
> >
> > For gen8+ "gt_" prefix would be better than pm_ on them
> > since these regs include more stuff then PM, but let's
> > keep for legacy reasons.
>
> I still disagree with this direction and would like to get the
> conflicting bug fixes reviewed first.
Sorry, I missunderstood you then...
I thought you were okay with intel_irq as long as we didn't
move rps related irq to it.
I still want to split de from gt irqs though, just started
from the easy less risk place to start.
About the bugs you mentioned you mean like this:
https://bugs.freedesktop.org/show_bug.cgi?id=109831
?
or what else do you have in mind that I'm missing?
Thanks,
Rodrigo
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-25 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 21:50 [PATCH 1/7] drm/i915: Introduce intel_irq Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 2/7] drm/i915: Move display_irqs_enabled to intel_irq Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 3/7] drm/i915: Move pm_imr and pm_ier to intel_irc Rodrigo Vivi
2019-04-25 22:16 ` Chris Wilson
2019-04-25 22:55 ` Rodrigo Vivi [this message]
2019-05-03 20:00 ` Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 4/7] drm/i915: Move all irq related masks to intel_irq Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 5/7] drm/i915: Prefer passing intel_irq instead of intel_uncore Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 6/7] drm/i915: Start the conversion from passing intel_irq instead of dev_priv/i915 Rodrigo Vivi
2019-04-25 21:50 ` [PATCH 7/7] drm/i915: Migrate more gen11 irq functions towards intel_irq and uncore funcs Rodrigo Vivi
2019-04-25 22:16 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Introduce intel_irq Patchwork
2019-04-25 22:35 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-26 10:05 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425225528.GQ588@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox