From: Patchwork <patchwork@emeril.freedesktop.org>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Refactor oa object to better manage resources
Date: Wed, 01 May 2019 17:15:05 -0000 [thread overview]
Message-ID: <20190501171505.14435.28304@emeril.freedesktop.org> (raw)
In-Reply-To: <20190501165046.30375-1-umesh.nerlige.ramappa@intel.com>
== Series Details ==
Series: drm/i915/perf: Refactor oa object to better manage resources
URL : https://patchwork.freedesktop.org/series/60176/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
aec4c50375a0 drm/i915/perf: Refactor oa object to better manage resources
-:1161: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stream->oa_buffer.last_ctx_id ==
stream->specific_ctx_id'
#1161: FILE: drivers/gpu/drm/i915/i915_perf.c:791:
+ if (!dev_priv->perf.exclusive_stream->ctx ||
+ stream->specific_ctx_id == ctx_id ||
+ (stream->oa_buffer.last_ctx_id ==
+ stream->specific_ctx_id) ||
reason & OAREPORT_REASON_CTX_SWITCH) {
-:1520: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#1520: FILE: drivers/gpu/drm/i915/i915_perf.c:1367:
+ BUG_ON(stream != dev_priv->perf.exclusive_stream);
-:1792: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1792: FILE: drivers/gpu/drm/i915/i915_perf.c:1838:
+ _MASKED_BIT_ENABLE(
-:2271: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2271: FILE: drivers/gpu/drm/i915/i915_perf.c:3479:
+ dev_priv->perf.gen8_valid_ctx_bit = (1<<25);
^
-:2279: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2279: FILE: drivers/gpu/drm/i915/i915_perf.c:3484:
+ dev_priv->perf.gen8_valid_ctx_bit = (1<<16);
^
-:2305: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2305: FILE: drivers/gpu/drm/i915/i915_perf.c:3502:
+ dev_priv->perf.gen8_valid_ctx_bit = (1<<16);
^
total: 0 errors, 1 warnings, 5 checks, 2163 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-01 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 16:50 [PATCH] drm/i915/perf: Refactor oa object to better manage resources Umesh Nerlige Ramappa
2019-05-01 17:15 ` Patchwork [this message]
2019-05-01 17:16 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-05-01 17:40 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-02 9:43 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-02 10:26 ` [PATCH] " Lionel Landwerlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501171505.14435.28304@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox