From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH] drm/i915/dp: use logical operators with boolean type
Date: Thu, 2 May 2019 11:29:53 +0300 [thread overview]
Message-ID: <20190502082953.31769-1-jani.nikula@intel.com> (raw)
Using arithmetic operators with booleans is confusing. Switch to logical
operators.
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 4e7b8d..ef4992f 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5094,7 +5094,7 @@ static void icl_update_tc_port_type(struct drm_i915_private *dev_priv,
enum port port = intel_dig_port->base.port;
enum tc_port_type old_type = intel_dig_port->tc_type;
- WARN_ON(is_legacy + is_typec + is_tbt != 1);
+ WARN_ON(is_legacy || is_typec || !is_tbt);
if (is_legacy)
intel_dig_port->tc_type = TC_PORT_LEGACY;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-05-02 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 8:29 Jani Nikula [this message]
2019-05-02 14:02 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: use logical operators with boolean type Patchwork
2019-05-02 15:30 ` [PATCH] " Paulo Zanoni
2019-05-03 7:30 ` Jani Nikula
2019-05-02 17:19 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: use logical operators with boolean type (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502082953.31769-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox