From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag
Date: Fri, 3 May 2019 14:35:59 +0200 [thread overview]
Message-ID: <20190503123559.GN3271@phenom.ffwll.local> (raw)
In-Reply-To: <877eb9oy77.fsf@intel.com>
On Thu, May 02, 2019 at 03:09:00PM +0300, Jani Nikula wrote:
> On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> > Looks like VBT contains again the wrong information about a port's TypeC
> > legacy vs. DP-alt/TBT-alt type. There is no further issues after we
> > notice this and fix it up, so tune down the WARN to be a a DRM_ERROR.
> >
> > This also avoids CI tainting the kernel and stopping the test run.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dp.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 4e7b8d29d733..07fa2670a677 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -5230,9 +5230,12 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
> > * WARN if we got a legacy port HPD, but VBT didn't mark the port as
> ^^^^
>
> With the comment fixed,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> > * legacy. Treat the port as legacy from now on.
> > */
> > - if (WARN_ON(!intel_dig_port->tc_legacy_port &&
> > - I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)))
> > + if (!intel_dig_port->tc_legacy_port &&
> > + I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)) {
> > + DRM_ERROR("VBT incorrectly claims port %c is not TypeC legacy\n",
> > + port_name(port));
> > intel_dig_port->tc_legacy_port = true;
DRM_ERRROR still causes CI failures (e.g. module reload, where I guess
this ends up in the logs).
If we really can fully fix it up I think a DRM_INFO is the right level.
-Daniel
> > + }
> > is_legacy = intel_dig_port->tc_legacy_port;
> >
> > /*
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-03 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 10:17 [PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag Imre Deak
2019-05-02 12:09 ` Jani Nikula
2019-05-03 12:35 ` Daniel Vetter [this message]
2019-05-03 13:08 ` Imre Deak
2019-05-02 14:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-05-02 16:57 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-02 20:05 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503123559.GN3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox