From: kbuild test robot <lkp@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
kbuild-all@01.org
Subject: Re: [PATCH] drm/i915: add force_probe module parameter to replace alpha_support
Date: Tue, 7 May 2019 05:46:29 +0800 [thread overview]
Message-ID: <201905070510.fo3THliv%lkp@intel.com> (raw)
In-Reply-To: <20190506134801.28751-1-jani.nikula@intel.com>
[-- Attachment #1: Type: text/plain, Size: 8043 bytes --]
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190506]
[cannot apply to v5.1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-add-force_probe-module-parameter-to-replace-alpha_support/20190507-045927
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x009-201918 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/firmware.h:7,
from drivers/gpu/drm/i915/intel_csr.c:25:
drivers/gpu/drm/i915/intel_csr.c: In function 'intel_csr_ucode_init':
>> drivers/gpu/drm/i915/intel_csr.c:532:12: error: implicit declaration of function 'IS_ALPHA_SUPPORT'; did you mean 'DP_PSR_SUPPORT'? [-Werror=implicit-function-declaration]
WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv)));
^
include/asm-generic/bug.h:131:25: note: in definition of macro 'WARN'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
>> drivers/gpu/drm/i915/intel_csr.c:532:3: note: in expansion of macro 'WARN_ON'
WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv)));
^~~~~~~
cc1: some warnings being treated as errors
vim +532 drivers/gpu/drm/i915/intel_csr.c
eb805623 Daniel Vetter 2015-05-04 462
aa9145c4 Animesh Manna 2015-05-13 463 /**
aa9145c4 Animesh Manna 2015-05-13 464 * intel_csr_ucode_init() - initialize the firmware loading.
f4448375 Daniel Vetter 2015-10-28 465 * @dev_priv: i915 drm device.
aa9145c4 Animesh Manna 2015-05-13 466 *
aa9145c4 Animesh Manna 2015-05-13 467 * This function is called at the time of loading the display driver to read
aa9145c4 Animesh Manna 2015-05-13 468 * firmware from a .bin file and copied into a internal memory.
aa9145c4 Animesh Manna 2015-05-13 469 */
f4448375 Daniel Vetter 2015-10-28 470 void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
eb805623 Daniel Vetter 2015-05-04 471 {
eb805623 Daniel Vetter 2015-05-04 472 struct intel_csr *csr = &dev_priv->csr;
8144ac59 Daniel Vetter 2015-10-28 473
8144ac59 Daniel Vetter 2015-10-28 474 INIT_WORK(&dev_priv->csr.work, csr_load_work_fn);
eb805623 Daniel Vetter 2015-05-04 475
f4448375 Daniel Vetter 2015-10-28 476 if (!HAS_CSR(dev_priv))
eb805623 Daniel Vetter 2015-05-04 477 return;
eb805623 Daniel Vetter 2015-05-04 478
d8a5b7d7 Jani Nikula 2018-09-26 479 /*
d8a5b7d7 Jani Nikula 2018-09-26 480 * Obtain a runtime pm reference, until CSR is loaded, to avoid entering
d8a5b7d7 Jani Nikula 2018-09-26 481 * runtime-suspend.
d8a5b7d7 Jani Nikula 2018-09-26 482 *
d8a5b7d7 Jani Nikula 2018-09-26 483 * On error, we return with the rpm wakeref held to prevent runtime
d8a5b7d7 Jani Nikula 2018-09-26 484 * suspend as runtime suspend *requires* a working CSR for whatever
d8a5b7d7 Jani Nikula 2018-09-26 485 * reason.
d8a5b7d7 Jani Nikula 2018-09-26 486 */
0e6e0be4 Chris Wilson 2019-01-14 487 intel_csr_runtime_pm_get(dev_priv);
d8a5b7d7 Jani Nikula 2018-09-26 488
02c07b76 Lucas De Marchi 2018-11-16 489 if (INTEL_GEN(dev_priv) >= 12) {
02c07b76 Lucas De Marchi 2018-11-16 490 /* Allow to load fw via parameter using the last known size */
02c07b76 Lucas De Marchi 2018-11-16 491 csr->max_fw_size = GEN12_CSR_MAX_FW_SIZE;
4b225248 Anusha Srivatsa 2019-03-22 492 } else if (IS_GEN(dev_priv, 11)) {
7fe78985 Jani Nikula 2018-09-27 493 csr->fw_path = ICL_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 494 csr->required_version = ICL_CSR_VERSION_REQUIRED;
d8a5b7d7 Jani Nikula 2018-09-26 495 csr->max_fw_size = ICL_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 496 } else if (IS_CANNONLAKE(dev_priv)) {
7fe78985 Jani Nikula 2018-09-27 497 csr->fw_path = CNL_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 498 csr->required_version = CNL_CSR_VERSION_REQUIRED;
7fe78985 Jani Nikula 2018-09-27 499 csr->max_fw_size = CNL_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 500 } else if (IS_GEMINILAKE(dev_priv)) {
7fe78985 Jani Nikula 2018-09-27 501 csr->fw_path = GLK_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 502 csr->required_version = GLK_CSR_VERSION_REQUIRED;
d8a5b7d7 Jani Nikula 2018-09-26 503 csr->max_fw_size = GLK_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 504 } else if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv)) {
7fe78985 Jani Nikula 2018-09-27 505 csr->fw_path = KBL_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 506 csr->required_version = KBL_CSR_VERSION_REQUIRED;
7fe78985 Jani Nikula 2018-09-27 507 csr->max_fw_size = KBL_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 508 } else if (IS_SKYLAKE(dev_priv)) {
7fe78985 Jani Nikula 2018-09-27 509 csr->fw_path = SKL_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 510 csr->required_version = SKL_CSR_VERSION_REQUIRED;
7fe78985 Jani Nikula 2018-09-27 511 csr->max_fw_size = SKL_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 512 } else if (IS_BROXTON(dev_priv)) {
7fe78985 Jani Nikula 2018-09-27 513 csr->fw_path = BXT_CSR_PATH;
180e9d23 Jani Nikula 2018-09-26 514 csr->required_version = BXT_CSR_VERSION_REQUIRED;
d8a5b7d7 Jani Nikula 2018-09-26 515 csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
180e9d23 Jani Nikula 2018-09-26 516 }
abd41dc9 Damien Lespiau 2015-06-04 517
d8a5b7d7 Jani Nikula 2018-09-26 518 if (i915_modparams.dmc_firmware_path) {
e7351a84 Jani Nikula 2018-09-26 519 if (strlen(i915_modparams.dmc_firmware_path) == 0) {
e7351a84 Jani Nikula 2018-09-26 520 csr->fw_path = NULL;
b598a88e Colin Ian King 2018-11-07 521 DRM_INFO("Disabling CSR firmware and runtime PM\n");
e7351a84 Jani Nikula 2018-09-26 522 return;
e7351a84 Jani Nikula 2018-09-26 523 }
e7351a84 Jani Nikula 2018-09-26 524
d8a5b7d7 Jani Nikula 2018-09-26 525 csr->fw_path = i915_modparams.dmc_firmware_path;
d8a5b7d7 Jani Nikula 2018-09-26 526 /* Bypass version check for firmware override. */
d8a5b7d7 Jani Nikula 2018-09-26 527 csr->required_version = 0;
d8a5b7d7 Jani Nikula 2018-09-26 528 }
dc174300 Suketu Shah 2015-04-17 529
ad3c776b Imre Deak 2018-08-15 530 if (csr->fw_path == NULL) {
ad3c776b Imre Deak 2018-08-15 531 DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n");
ad3c776b Imre Deak 2018-08-15 @532 WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv)));
ad3c776b Imre Deak 2018-08-15 533
ad3c776b Imre Deak 2018-08-15 534 return;
ad3c776b Imre Deak 2018-08-15 535 }
ad3c776b Imre Deak 2018-08-15 536
ad3c776b Imre Deak 2018-08-15 537 DRM_DEBUG_KMS("Loading %s\n", csr->fw_path);
8144ac59 Daniel Vetter 2015-10-28 538 schedule_work(&dev_priv->csr.work);
eb805623 Daniel Vetter 2015-05-04 539 }
eb805623 Daniel Vetter 2015-05-04 540
:::::: The code at line 532 was first introduced by commit
:::::: ad3c776b171078a10ace07616a34ed6266beb0e7 drm/i915: Fix PM refcounting w/o DMC firmware
:::::: TO: Imre Deak <imre.deak@intel.com>
:::::: CC: Imre Deak <imre.deak@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26624 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-06 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 13:48 [PATCH] drm/i915: add force_probe module parameter to replace alpha_support Jani Nikula
2019-05-06 14:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-05-06 14:09 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-06 14:32 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-06 16:35 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-06 21:46 ` kbuild test robot [this message]
2019-05-21 16:49 ` [PATCH] " Rodrigo Vivi
2019-05-31 13:47 ` Jani Nikula
2019-05-31 9:40 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905070510.fo3THliv%lkp@intel.com \
--to=lkp@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox