From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 00/11] drm/i915: Add support for asynchronous display power disabling
Date: Thu, 9 May 2019 19:25:44 +0300 [thread overview]
Message-ID: <20190509162544.GI24299@intel.com> (raw)
In-Reply-To: <20190509061954.10379-1-imre.deak@intel.com>
On Thu, May 09, 2019 at 09:19:43AM +0300, Imre Deak wrote:
> This patchset is v2 of [1]. The main change is the rework of patch 1
> based on Chris' feedback.
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
>
> [1] https://patchwork.freedesktop.org/series/60242/
>
> Imre Deak (11):
> drm/i915: Add support for tracking wakerefs w/o power-on guarantee
> drm/i915: Force printing wakeref tacking during pm_cleanup
> drm/i915: Verify power domains state during suspend in all cases
> drm/i915: Add support for asynchronous display power disabling
> drm/i915: Disable power asynchronously during DP AUX transfers
> drm/i915: WARN for eDP encoders in intel_dp_detect_dpcd()
> drm/i915: Remove the unneeded AUX power ref from intel_dp_detect()
> drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse()
> drm/i915: Replace use of PLLS power domain with DISPLAY_CORE domain
> drm/i915: Avoid taking the PPS lock for non-eDP/VLV/CHV
> drm/i915: Assert that TypeC ports are not used for eDP
I trust Chris scrutinized the wakeref stuff sufficiently so
I didn't pay all that much attention to those patches.
Patches 5-11 lgtm.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drivers/gpu/drm/i915/i915_drv.h | 5 +
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_display.h | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 83 ++--
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 36 +-
> drivers/gpu/drm/i915/intel_drv.h | 52 ++-
> drivers/gpu/drm/i915/intel_psr.c | 6 +
> drivers/gpu/drm/i915/intel_runtime_pm.c | 595 +++++++++++++++++++++---
> drivers/gpu/drm/i915/intel_runtime_pm.h | 8 +
> 9 files changed, 662 insertions(+), 127 deletions(-)
>
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-05-09 16:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 6:19 [PATCH v2 00/11] drm/i915: Add support for asynchronous display power disabling Imre Deak
2019-05-09 6:19 ` [PATCH v2 01/11] drm/i915: Add support for tracking wakerefs w/o power-on guarantee Imre Deak
2019-05-09 8:03 ` Chris Wilson
2019-05-09 9:58 ` Imre Deak
2019-05-09 6:19 ` [PATCH v2 02/11] drm/i915: Force printing wakeref tacking during pm_cleanup Imre Deak
2019-05-09 8:05 ` Chris Wilson
2019-05-09 6:19 ` [PATCH v2 03/11] drm/i915: Verify power domains state during suspend in all cases Imre Deak
2019-05-09 8:05 ` Chris Wilson
2019-05-09 6:19 ` [PATCH v2 04/11] drm/i915: Add support for asynchronous display power disabling Imre Deak
2019-05-09 8:17 ` Chris Wilson
2019-05-09 10:46 ` Imre Deak
2019-05-09 6:19 ` [PATCH v2 05/11] drm/i915: Disable power asynchronously during DP AUX transfers Imre Deak
2019-05-09 6:19 ` [PATCH v2 06/11] drm/i915: WARN for eDP encoders in intel_dp_detect_dpcd() Imre Deak
2019-05-09 6:19 ` [PATCH v2 07/11] drm/i915: Remove the unneeded AUX power ref from intel_dp_detect() Imre Deak
2019-05-09 15:57 ` Ville Syrjälä
2019-05-09 16:10 ` Imre Deak
2019-05-09 6:19 ` [PATCH v2 08/11] drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse() Imre Deak
2019-05-09 15:50 ` Ville Syrjälä
2019-05-09 16:06 ` Imre Deak
2019-05-09 6:19 ` [PATCH v2 09/11] drm/i915: Replace use of PLLS power domain with DISPLAY_CORE domain Imre Deak
2019-05-09 6:19 ` [PATCH v2 10/11] drm/i915: Avoid taking the PPS lock for non-eDP/VLV/CHV Imre Deak
2019-05-09 6:19 ` [PATCH v2 11/11] drm/i915: Assert that TypeC ports are not used for eDP Imre Deak
2019-05-09 8:42 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for asynchronous display power disabling (rev3) Patchwork
2019-05-09 9:09 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-09 10:21 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-09 16:25 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509162544.GI24299@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox