From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/icl: Fixed Input CSC Co-efficients for BT601/709
Date: Thu, 9 May 2019 22:24:02 +0300 [thread overview]
Message-ID: <20190509192402.GK24299@intel.com> (raw)
In-Reply-To: <1557429108-8004-4-git-send-email-uma.shankar@intel.com>
On Fri, May 10, 2019 at 12:41:48AM +0530, Uma Shankar wrote:
> Input CSC Co-efficients for BT601 and BT709 YCbCR to RGB
> conversion were slightly off. Fixed the same.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index c9c970f..1239457 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -430,7 +430,7 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
> */
> [DRM_COLOR_YCBCR_BT709] = {
> 0x7C98, 0x7800, 0x0,
> - 0x9EF8, 0x7800, 0xABF8,
> + 0x9EF8, 0x7800, 0xAC00,
> 0x0, 0x7800, 0x7ED8,
> },
> /*
> @@ -453,25 +453,25 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
> * BT.601 Limted range YCbCr -> full range RGB
> * The matrix required is :
> * [1.164384, 0.000, 1.596370,
> - * 1.138393, -0.382500, -0.794598,
> - * 1.138393, 1.971696, 0.0000]
> + * 1.164384, -0.382500, -0.794598,
> + * 1.164384, 1.971696, 0.0000]
Still not quite what I'm getting here:
1.164384 0.000000 1.596027
1.164384 -0.391762 -0.812968
1.164384 2.017232 0.000000
> */
> [DRM_COLOR_YCBCR_BT601] = {
> - 0x7CC8, 0x7950, 0x0,
> - 0x8CB8, 0x7918, 0x9C40,
> - 0x0, 0x7918, 0x7FC8,
> + 0x7C80, 0x7950, 0x0,
> + 0x8CB8, 0x7950, 0x9C40,
> + 0x0, 0x7950, 0x7FC8,
> },
> /*
> * BT.709 Limited range YCbCr -> full range RGB
> * The matrix required is :
> - * [1.164, 0.000, 1.833671,
> - * 1.138393, -0.213249, -0.532909,
> - * 1.138393, 2.112402, 0.0000]
> + * [1.164384, 0.000, 1.792741,
> + * 1.164384, -0.213249, -0.532909,
> + * 1.164384, 2.112402, 0.0000]
> */
This one matches what I'm getting.
> [DRM_COLOR_YCBCR_BT709] = {
> - 0x7EA8, 0x7950, 0x0,
> - 0x8888, 0x7918, 0xADA8,
> - 0x0, 0x7918, 0x6870,
> + 0x7E58, 0x7950, 0x0,
> + 0x8888, 0x7950, 0xADA8,
> + 0x0, 0x7950, 0x6870,
> },
> /*
> * BT.2020 Limited range YCbCr -> full range RGB
> --
> 1.9.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-09 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 19:11 [PATCH 0/3] Extend BT2020 support in iCSC and fixes Uma Shankar
2019-05-09 19:11 ` [PATCH 1/3] drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case Uma Shankar
2019-05-09 19:11 ` [PATCH 2/3] drm/i915/icl: Fix Y pre-offset for Full Range YCbCr Uma Shankar
2019-05-09 19:11 ` [PATCH 3/3] drm/i915/icl: Fixed Input CSC Co-efficients for BT601/709 Uma Shankar
2019-05-09 19:24 ` Ville Syrjälä [this message]
2019-05-09 19:37 ` Shankar, Uma
2019-05-09 20:18 ` [v2] " Uma Shankar
2019-05-09 19:37 ` ✓ Fi.CI.BAT: success for Extend BT2020 support in iCSC and fixes Patchwork
2019-05-09 20:38 ` ✓ Fi.CI.BAT: success for Extend BT2020 support in iCSC and fixes (rev2) Patchwork
2019-05-10 5:39 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509192402.GK24299@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox