public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Per context and per client GPU busyness tracking
Date: Fri, 10 May 2019 14:13:33 -0000	[thread overview]
Message-ID: <20190510141333.17666.79217@emeril.freedesktop.org> (raw)
In-Reply-To: <20190510132240.11029-1-tvrtko.ursulin@linux.intel.com>

== Series Details ==

Series: Per context and per client GPU busyness tracking
URL   : https://patchwork.freedesktop.org/series/60506/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3ae0f10d21d1 drm/i915: Move intel_engine_context_in/out into intel_lrc.c
e76b877d4273 drm/i915: Track per-context engine busyness
83be221853b1 drm/i915: Expose list of clients in sysfs
-:96: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#96: FILE: drivers/gpu/drm/i915/i915_gem.c:4839:
+i915_gem_add_client(struct drm_i915_private *i915,
+		struct drm_i915_file_private *file_priv,

total: 0 errors, 0 warnings, 1 checks, 201 lines checked
4912359f0d14 drm/i915: Update client name on context create
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/i915_drv.h:3092:
+i915_gem_add_client(struct drm_i915_private *i915,
+		struct drm_i915_file_private *file_priv,

total: 0 errors, 0 warnings, 1 checks, 68 lines checked
4c2ec282f33b drm/i915: Expose per-engine client busyness
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
     Render/3D/0   63.73% |███████████████████           |      3%      0%

-:95: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#95: FILE: drivers/gpu/drm/i915/i915_gem.c:4849:
+	uint64_t total = bc->total;

-:128: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#128: FILE: drivers/gpu/drm/i915/i915_gem.c:4882:
+static const char *uabi_class_names[] = {

-:185: ERROR:CODE_INDENT: code indent should use tabs where possible
#185: FILE: drivers/gpu/drm/i915/i915_gem.c:4955:
+^I^I^I^I        (struct attribute *)attr);$

-:185: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#185: FILE: drivers/gpu/drm/i915/i915_gem.c:4955:
+		ret = sysfs_create_file(file_priv->client.busy_root,
+				        (struct attribute *)attr);

total: 1 errors, 2 warnings, 2 checks, 161 lines checked
816d25263191 drm/i915: Add sysfs toggle to enable per-client engine stats

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-10 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 13:22 [RFC 0/6] Per context and per client GPU busyness tracking Tvrtko Ursulin
2019-05-10 13:22 ` [RFC 1/6] drm/i915: Move intel_engine_context_in/out into intel_lrc.c Tvrtko Ursulin
2019-05-10 13:22 ` [RFC 2/6] drm/i915: Track per-context engine busyness Tvrtko Ursulin
2019-05-10 14:22   ` Chris Wilson
2019-05-10 13:22 ` [RFC 3/6] drm/i915: Expose list of clients in sysfs Tvrtko Ursulin
2019-05-10 14:12   ` Chris Wilson
2019-05-10 13:22 ` [RFC 4/6] drm/i915: Update client name on context create Tvrtko Ursulin
2019-05-10 13:22 ` [RFC 5/6] drm/i915: Expose per-engine client busyness Tvrtko Ursulin
2019-05-10 13:57   ` Chris Wilson
2019-05-10 14:02     ` Tvrtko Ursulin
2019-05-10 13:22 ` [RFC 6/6] drm/i915: Add sysfs toggle to enable per-client engine stats Tvrtko Ursulin
2019-05-10 14:13 ` Patchwork [this message]
2019-05-10 15:06 ` ✓ Fi.CI.BAT: success for Per context and per client GPU busyness tracking Patchwork
2019-05-10 16:48 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510141333.17666.79217@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox