From: Ramalingam C <ramalingam.c@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count
Date: Fri, 17 May 2019 18:25:21 +0530 [thread overview]
Message-ID: <20190517125521.GA4714@intel.com> (raw)
In-Reply-To: <20190517102225.3069-3-chris@chris-wilson.co.uk>
On 2019-05-17 at 11:22:25 +0100, Chris Wilson wrote:
> Smatch spotted:
> drivers/gpu/drm/i915//intel_hdcp.c:1406 hdcp2_authenticate_repeater_topology() warn: should this be a bitwise op?
>
> and indeed looks to be suspect that we do need to use a bitwise or to
> combine the two register fields into one counter.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ramalingam C <ramalingam.c@intel.com>
Thanks for fixing it.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
-Ram
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 53df2f2376e8..bc3a94d491c4 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -1402,8 +1402,8 @@ int hdcp2_authenticate_repeater_topology(struct intel_connector *connector)
> return -EINVAL;
> }
>
> - device_cnt = HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 ||
> - HDCP_2_2_DEV_COUNT_LO(rx_info[1]);
> + device_cnt = (HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 |
> + HDCP_2_2_DEV_COUNT_LO(rx_info[1]));
> if (drm_hdcp_check_ksvs_revoked(dev, msgs.recvid_list.receiver_ids,
> device_cnt)) {
> DRM_ERROR("Revoked receiver ID(s) is in list\n");
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-17 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
2019-05-17 10:22 ` [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis Chris Wilson
2019-05-17 12:09 ` Imre Deak
2019-05-17 10:22 ` [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count Chris Wilson
2019-05-17 12:55 ` Ramalingam C [this message]
2019-05-17 12:46 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Patchwork
2019-05-17 13:01 ` [PATCH 1/3] " Ramalingam C
2019-05-17 13:10 ` Ramalingam C
2019-05-17 13:39 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2019-05-17 19:38 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-20 2:51 ` [PATCH 1/3] " Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517125521.GA4714@intel.com \
--to=ramalingam.c@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox