From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
intel-gfx@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Sean Paul <sean@poorly.run>
Subject: [PATCH v2 0/7] drm: make headers self-contained and drop drmP.h
Date: Sun, 26 May 2019 19:35:28 +0200 [thread overview]
Message-ID: <20190526173535.32701-1-sam@ravnborg.org> (raw)
While removing use of drmP.h from files in drm/* I
noticed that I had to add the same include files due to
dependencies in the header files.
It is better to let the header files be self-contained and
let the users pull in only the additional headers files required.
So I went ahead and made the relevant header files self-contained.
(I did not check if this made any includes redundant in some files,
I do not have tooling in place to do so).
Daniel suggested to add support for testing that they stay
self contained.
Jani Nikula has sent a patch to kbuild to make this part of the
kbuild machinery. I have used it locally and as soon as it
lands in kbuild I will start using it for drm.
We could have duplicated the infrastructure now but that seemed
too much code chrunch.
This patchset include the actual removal of drmP.h as one big patch.
This is build tested on alpha (always interesting), arm, arm64, x86 etc.
For all files touched the following was done:
- include files divided up in blocks in following order:
linux/*
video/*
drm/*
""
- within each block the include files are sorted alphabetically
v2:
- use same ordering af blocks
- move includes down below license text
- added patch with actual drmP.h removal
- reworded some subjects to make them more descriptive
- fixed a few spelling erros in changelogs (but a few may remain)
Sam
Sam Ravnborg (7):
drm: make drm/drm_auth.h self contained
drm: make drm/drm_legacy.h self-contained
drm: make drm_crtc_internal.h self-contained
drm: make drm_internal.h self-contained
drm: make drm_legacy.h self-contained
drm: make drm_trace.h self-contained
drm: drop use of drmP.h in drm/*
drivers/gpu/drm/ati_pcigart.c | 5 ++++-
drivers/gpu/drm/drm_agpsupport.c | 11 +++++++++--
drivers/gpu/drm/drm_atomic.c | 9 +++++++--
drivers/gpu/drm/drm_atomic_helper.c | 11 +++++++----
drivers/gpu/drm/drm_atomic_state_helper.c | 7 ++++---
drivers/gpu/drm/drm_auth.c | 10 ++++++++--
drivers/gpu/drm/drm_blend.c | 9 ++++++---
drivers/gpu/drm/drm_bufs.c | 21 ++++++++++++++++-----
drivers/gpu/drm/drm_client.c | 2 +-
drivers/gpu/drm/drm_color_mgmt.c | 8 ++++++--
drivers/gpu/drm/drm_context.c | 8 +++++++-
drivers/gpu/drm/drm_crtc_helper.c | 14 ++++++++------
drivers/gpu/drm/drm_crtc_internal.h | 24 ++++++++++++++++++++----
drivers/gpu/drm/drm_debugfs.c | 13 ++++++++-----
drivers/gpu/drm/drm_debugfs_crc.c | 9 ++++++++-
drivers/gpu/drm/drm_dma.c | 6 +++++-
drivers/gpu/drm/drm_drv.c | 9 ++++++---
drivers/gpu/drm/drm_dumb_buffers.c | 4 +++-
drivers/gpu/drm/drm_encoder.c | 4 +++-
drivers/gpu/drm/drm_fb_helper.c | 19 ++++++++++++-------
drivers/gpu/drm/drm_file.c | 11 +++++++----
drivers/gpu/drm/drm_flip_work.c | 6 ++++--
drivers/gpu/drm/drm_fourcc.c | 2 +-
drivers/gpu/drm/drm_framebuffer.c | 13 +++++++++----
drivers/gpu/drm/drm_gem.c | 8 ++++++--
drivers/gpu/drm/drm_gem_cma_helper.c | 11 ++++++-----
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 1 -
drivers/gpu/drm/drm_hashtab.c | 10 +++++++---
drivers/gpu/drm/drm_internal.h | 10 +++++++++-
drivers/gpu/drm/drm_ioc32.c | 9 ++++++---
drivers/gpu/drm/drm_ioctl.c | 22 ++++++++++++++--------
drivers/gpu/drm/drm_irq.c | 13 +++++++++----
drivers/gpu/drm/drm_kms_helper_common.c | 3 ++-
drivers/gpu/drm/drm_lease.c | 15 ++++++++++-----
drivers/gpu/drm/drm_legacy.h | 4 ++++
drivers/gpu/drm/drm_legacy_misc.c | 7 ++++++-
drivers/gpu/drm/drm_lock.c | 8 ++++++--
drivers/gpu/drm/drm_memory.c | 9 +++++++--
drivers/gpu/drm/drm_mm.c | 9 +++++----
drivers/gpu/drm/drm_mode_config.c | 6 +++++-
drivers/gpu/drm/drm_mode_object.c | 9 +++++++--
drivers/gpu/drm/drm_modes.c | 7 +++++--
drivers/gpu/drm/drm_modeset_lock.c | 2 +-
drivers/gpu/drm/drm_of.c | 5 +++--
drivers/gpu/drm/drm_pci.c | 11 ++++++++---
drivers/gpu/drm/drm_plane_helper.c | 9 +++++----
drivers/gpu/drm/drm_prime.c | 7 +++++--
drivers/gpu/drm/drm_print.c | 7 ++++++-
drivers/gpu/drm/drm_probe_helper.c | 7 ++++---
drivers/gpu/drm/drm_property.c | 7 ++++++-
drivers/gpu/drm/drm_rect.c | 4 +++-
drivers/gpu/drm/drm_scatter.c | 9 +++++++--
drivers/gpu/drm/drm_scdc_helper.c | 2 +-
drivers/gpu/drm/drm_simple_kms_helper.c | 5 +++--
drivers/gpu/drm/drm_syncobj.c | 13 +++++++++----
drivers/gpu/drm/drm_sysfs.c | 15 +++++++++++----
drivers/gpu/drm/drm_trace.h | 2 ++
drivers/gpu/drm/drm_trace_points.c | 3 ++-
drivers/gpu/drm/drm_vblank.c | 12 +++++++++---
drivers/gpu/drm/drm_vm.c | 14 +++++++++++++-
drivers/gpu/drm/drm_vma_manager.c | 6 +++---
drivers/gpu/drm/drm_vram_mm_helper.c | 4 +++-
drivers/gpu/drm/drm_writeback.c | 6 ++++--
include/drm/drm_auth.h | 11 +++++++++--
include/drm/drm_legacy.h | 12 ++++++------
65 files changed, 406 insertions(+), 163 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-05-26 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 17:35 Sam Ravnborg [this message]
2019-05-26 17:35 ` [PATCH v2 1/7] drm: make drm/drm_auth.h self contained Sam Ravnborg
2019-05-28 12:54 ` Jani Nikula
2019-05-28 13:07 ` Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 2/7] drm: make drm/drm_legacy.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 3/7] drm: make drm_crtc_internal.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 4/7] drm: make drm_internal.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 5/7] drm: make drm_legacy.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 6/7] drm: make drm_trace.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 7/7] drm: drop use of drmP.h in drm/* Sam Ravnborg
2019-05-26 18:05 ` ✗ Fi.CI.CHECKPATCH: warning for drm: make headers self-contained and drop drmP.h Patchwork
2019-05-26 18:08 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-26 18:25 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-27 6:18 ` [PATCH v2 0/7] " Daniel Vetter
2019-05-27 6:54 ` Sam Ravnborg
2019-05-27 18:05 ` Sam Ravnborg
2019-05-27 12:00 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526173535.32701-1-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox