From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case
Date: Tue, 28 May 2019 20:49:25 +0300 [thread overview]
Message-ID: <20190528174925.GP5942@intel.com> (raw)
In-Reply-To: <a8876aac-bdab-30df-1354-3b7235faf4bc@linux.intel.com>
On Tue, May 28, 2019 at 12:51:04PM +0200, Maarten Lankhorst wrote:
> Op 13-05-2019 om 15:39 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Leave a hint in dmesg when we reject a configuration attempting
> > to use C8 planes without the legacy LUT loaded.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_color.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> > index 962db1236970..45649904ba5c 100644
> > --- a/drivers/gpu/drm/i915/intel_color.c
> > +++ b/drivers/gpu/drm/i915/intel_color.c
> > @@ -959,8 +959,10 @@ static int check_luts(const struct intel_crtc_state *crtc_state)
> > return 0;
> >
> > /* C8 relies on its palette being stored in the legacy LUT */
> > - if (crtc_state->c8_planes)
> > + if (crtc_state->c8_planes) {
> > + DRM_DEBUG_KMS("C8 pixelformat requires the legacy LUT\n");
> > return -EINVAL;
> > + }
> >
> > degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size;
> > gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size;
>
> For the series:
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thanks. Pushed.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-28 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
2019-05-13 13:39 ` [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled Ville Syrjala
2019-05-13 13:39 ` [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case Ville Syrjala
2019-05-28 10:51 ` Maarten Lankhorst
2019-05-28 17:49 ` Ville Syrjälä [this message]
2019-05-13 16:20 ` ✓ Fi.CI.BAT: success for drm/i915: C8 fix Patchwork
2019-05-13 21:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-28 13:03 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528174925.GP5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox