From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/icl: Ensure port A combo PHY HW state is correct
Date: Fri, 31 May 2019 15:33:22 +0300 [thread overview]
Message-ID: <20190531123322.GT5942@intel.com> (raw)
In-Reply-To: <20190531082626.30640-1-imre.deak@intel.com>
On Fri, May 31, 2019 at 11:26:26AM +0300, Imre Deak wrote:
> Make sure the HW state of the port A combo PHY is correct wrt. the
> IREFGEN setting. This will force a reprogramming during init or a WARN
> during uninit if the setting is incorrect.
>
> On my ICL RVP I haven't seen this check failing and leading to a forced
> reinit/WARN, but let's add it still for consistency.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_combo_phy.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
> index 98213cc58736..841708da5a56 100644
> --- a/drivers/gpu/drm/i915/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/intel_combo_phy.c
> @@ -198,6 +198,10 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv,
>
> ret = cnl_verify_procmon_ref_values(dev_priv, port);
>
> + if (port == PORT_A)
> + ret &= check_phy_reg(dev_priv, port, ICL_PORT_COMP_DW8(port),
> + IREFGEN, IREFGEN);
> +
> ret &= check_phy_reg(dev_priv, port, ICL_PORT_CL_DW5(port),
> CL_POWER_DOWN_ENABLE, CL_POWER_DOWN_ENABLE);
>
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-31 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 8:26 [PATCH] drm/i915/icl: Ensure port A combo PHY HW state is correct Imre Deak
2019-05-31 12:33 ` Ville Syrjälä [this message]
2019-05-31 14:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-01 11:38 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-01 15:20 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531123322.GT5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox