public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for split out intel_display_power
Date: Fri, 31 May 2019 22:50:25 -0000	[thread overview]
Message-ID: <20190531225025.20998.7455@emeril.freedesktop.org> (raw)
In-Reply-To: <20190531222409.9177-1-daniele.ceraolospurio@intel.com>

== Series Details ==

Series: split out intel_display_power
URL   : https://patchwork.freedesktop.org/series/61453/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
757791efed23 drm/i915: extract intel_display_power.h/c from intel_runtime_pm.h/c
-:64: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#64: 
new file mode 100644

-:69: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/intel_display_power.c', please use '//' instead
#69: FILE: drivers/gpu/drm/i915/intel_display_power.c:1:
+/* SPDX-License-Identifier: MIT */

-:69: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#69: FILE: drivers/gpu/drm/i915/intel_display_power.c:1:
+/* SPDX-License-Identifier: MIT */

-:332: CHECK:LINE_SPACING: Please don't use multiple blank lines
#332: FILE: drivers/gpu/drm/i915/intel_display_power.c:264:
+
+

-:406: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pg' should also have an identifier name
#406: FILE: drivers/gpu/drm/i915/intel_display_power.c:338:
+	enum skl_power_gate uninitialized_var(pg);

-:931: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#931: FILE: drivers/gpu/drm/i915/intel_display_power.c:863:
+static bool i9xx_always_on_power_well_enabled(struct drm_i915_private *dev_priv,
+					     struct i915_power_well *power_well)

-:1198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects?
#1198: FILE: drivers/gpu/drm/i915/intel_display_power.c:1130:
+#define BITS_SET(val, bits) (((val) & (bits)) == (bits))

-:3517: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well_descs' - possible side-effects?
#3517: FILE: drivers/gpu/drm/i915/intel_display_power.c:3449:
+#define set_power_wells(power_domains, __power_well_descs) \
+	__set_power_wells(power_domains, __power_well_descs, \
+			  ARRAY_SIZE(__power_well_descs))

-:3621: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#3621: FILE: drivers/gpu/drm/i915/intel_display_power.c:3553:
+	udelay(10);

-:3678: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#3678: FILE: drivers/gpu/drm/i915/intel_display_power.c:3610:
+	udelay(10);

-:3697: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#3697: FILE: drivers/gpu/drm/i915/intel_display_power.c:3629:
+	udelay(10);

-:3987: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#3987: FILE: drivers/gpu/drm/i915/intel_display_power.c:3919:
+static void skl_display_core_init(struct drm_i915_private *dev_priv,
+				   bool resume)

-:4528: WARNING:LINE_SPACING: Missing a blank line after declarations
#4528: FILE: drivers/gpu/drm/i915/intel_display_power.c:4460:
+	struct i915_power_domains *power_domains = &i915->power_domains;
+	intel_wakeref_t wakeref __maybe_unused =

-:4707: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name
#4707: FILE: drivers/gpu/drm/i915/intel_display_power.h:21:
+int intel_power_domains_init(struct drm_i915_private *);

-:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84:
+#define with_intel_display_power(i915, domain, wf) \
+	for ((wf) = intel_display_power_get((i915), (domain)); (wf); \
+	     intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0)

-:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects?
#4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84:
+#define with_intel_display_power(i915, domain, wf) \
+	for ((wf) = intel_display_power_get((i915), (domain)); (wf); \
+	     intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0)

-:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84:
+#define with_intel_display_power(i915, domain, wf) \
+	for ((wf) = intel_display_power_get((i915), (domain)); (wf); \
+	     intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0)

total: 0 errors, 6 warnings, 11 checks, 9706 lines checked
392ffe04011b drm/i915: move more defs in intel_display_power.h
-:304: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tran' - possible side-effects?
#304: FILE: drivers/gpu/drm/i915/intel_display_power.h:70:
+#define POWER_DOMAIN_TRANSCODER(tran) \
+	((tran) == TRANSCODER_EDP ? POWER_DOMAIN_TRANSCODER_EDP : \
+	 (tran) + POWER_DOMAIN_TRANSCODER_A)

-:407: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#407: FILE: drivers/gpu/drm/i915/intel_display_power.h:173:
+	struct mutex lock;

-:417: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects?
#417: FILE: drivers/gpu/drm/i915/intel_display_power.h:183:
+#define for_each_power_domain(domain, mask)				\
+	for ((domain) = 0; (domain) < POWER_DOMAIN_NUM; (domain)++)	\
+		for_each_if(BIT_ULL(domain) & (mask))

-:421: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects?
#421: FILE: drivers/gpu/drm/i915/intel_display_power.h:187:
+#define for_each_power_well(__dev_priv, __power_well)				\
+	for ((__power_well) = (__dev_priv)->power_domains.power_wells;	\
+	     (__power_well) - (__dev_priv)->power_domains.power_wells <	\
+		(__dev_priv)->power_domains.power_well_count;		\
+	     (__power_well)++)

-:421: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#421: FILE: drivers/gpu/drm/i915/intel_display_power.h:187:
+#define for_each_power_well(__dev_priv, __power_well)				\
+	for ((__power_well) = (__dev_priv)->power_domains.power_wells;	\
+	     (__power_well) - (__dev_priv)->power_domains.power_wells <	\
+		(__dev_priv)->power_domains.power_well_count;		\
+	     (__power_well)++)

-:427: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects?
#427: FILE: drivers/gpu/drm/i915/intel_display_power.h:193:
+#define for_each_power_well_reverse(__dev_priv, __power_well)			\
+	for ((__power_well) = (__dev_priv)->power_domains.power_wells +		\
+			      (__dev_priv)->power_domains.power_well_count - 1;	\
+	     (__power_well) - (__dev_priv)->power_domains.power_wells >= 0;	\
+	     (__power_well)--)

-:427: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#427: FILE: drivers/gpu/drm/i915/intel_display_power.h:193:
+#define for_each_power_well_reverse(__dev_priv, __power_well)			\
+	for ((__power_well) = (__dev_priv)->power_domains.power_wells +		\
+			      (__dev_priv)->power_domains.power_well_count - 1;	\
+	     (__power_well) - (__dev_priv)->power_domains.power_wells >= 0;	\
+	     (__power_well)--)

-:433: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#433: FILE: drivers/gpu/drm/i915/intel_display_power.h:199:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask)	\
+	for_each_power_well(__dev_priv, __power_well)				\
+		for_each_if((__power_well)->desc->domains & (__domain_mask))

-:433: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#433: FILE: drivers/gpu/drm/i915/intel_display_power.h:199:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask)	\
+	for_each_power_well(__dev_priv, __power_well)				\
+		for_each_if((__power_well)->desc->domains & (__domain_mask))

-:437: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#437: FILE: drivers/gpu/drm/i915/intel_display_power.h:203:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+	for_each_power_well_reverse(__dev_priv, __power_well)		        \
+		for_each_if((__power_well)->desc->domains & (__domain_mask))

-:437: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#437: FILE: drivers/gpu/drm/i915/intel_display_power.h:203:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+	for_each_power_well_reverse(__dev_priv, __power_well)		        \
+		for_each_if((__power_well)->desc->domains & (__domain_mask))

total: 2 errors, 0 warnings, 9 checks, 412 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-31 22:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 22:24 [PATCH 0/2] split out intel_display_power Daniele Ceraolo Spurio
2019-05-31 22:24 ` [PATCH 1/2] drm/i915: extract intel_display_power.h/c from intel_runtime_pm.h/c Daniele Ceraolo Spurio
2019-06-01  8:45   ` Chris Wilson
2019-05-31 22:24 ` [PATCH 2/2] drm/i915: move more defs in intel_display_power.h Daniele Ceraolo Spurio
2019-06-01  8:46   ` Chris Wilson
2019-05-31 22:50 ` Patchwork [this message]
2019-05-31 22:52 ` ✗ Fi.CI.SPARSE: warning for split out intel_display_power Patchwork
2019-05-31 23:30 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-01  8:45 ` [PATCH 0/2] " Chris Wilson
2019-06-03 18:43   ` Jani Nikula
2019-06-04  7:12     ` Imre Deak
2019-06-04  7:34       ` Chris Wilson
2019-06-02  3:36 ` ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190531225025.20998.7455@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox