public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Make the semaphore saturation mask global
Date: Mon, 03 Jun 2019 16:56:18 -0000	[thread overview]
Message-ID: <20190603165618.25580.57782@emeril.freedesktop.org> (raw)
In-Reply-To: <20190603135910.15979-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [01/15] drm/i915: Make the semaphore saturation mask global
URL   : https://patchwork.freedesktop.org/series/61524/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
73098627036b drm/i915: Make the semaphore saturation mask global
03932e224987 drm: Flush output polling on shutdown
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
<4> [341.846497] WARNING: CPU: 3 PID: 3300 at kernel/locking/mutex-debug.c:103 mutex_destroy+0x49/0x50

total: 0 errors, 1 warnings, 0 checks, 21 lines checked
bef084dfd0fc drm/i915/selftests: Flush partial-tiling object once
5518d5a5bcf1 drm/i915: Use unchecked writes for setting up the fences
88a48ffab798 drm/i915: Use unchecked unccore writes to flush the GTT
fb725e75a68e drm/i915: Report an earlier wedged event when suspending the engines
0505eaa83ac9 drm/i915: Move object close under its own lock
b875658ce204 drm/i915: Keep contexts pinned until after the next kernel context switch
4f00dab1b645 drm/i915: Stop retiring along engine
5c83798408f4 drm/i915: Replace engine->timeline with a plain list
-:180: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#180: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:292:
+		spinlock_t lock;

total: 0 errors, 0 warnings, 1 checks, 968 lines checked
a3bd899e85cb drm/i915: Flush the execution-callbacks on retiring
687140deab24 drm/i915/execlists: Preempt-to-busy
-:1494: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1494: FILE: drivers/gpu/drm/i915/i915_utils.h:134:
+#define ptr_count_dec(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(--__v);					\
+} while (0)

-:1500: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1500: FILE: drivers/gpu/drm/i915/i915_utils.h:140:
+#define ptr_count_inc(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(++__v);					\
+} while (0)

-:1783: WARNING:LINE_SPACING: Missing a blank line after declarations
#1783: FILE: drivers/gpu/drm/i915/intel_guc_submission.c:820:
+		int rem = ARRAY_SIZE(execlists->inflight) - idx;
+		memmove(execlists->inflight, port, rem * sizeof(*port));

total: 0 errors, 1 warnings, 2 checks, 1682 lines checked
db2939f074b6 drm/i915/execlists: Minimalistic timeslicing
-:345: WARNING:LONG_LINE: line over 100 characters
#345: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:211:
+			      2 * RUNTIME_INFO(outer->i915)->num_engines * (count + 2) * (count + 3)) < 0) {

total: 0 errors, 1 warnings, 0 checks, 426 lines checked
2b1890df5891 drm/i915/execlists: Force preemption
-:51: WARNING:LONG_LINE: line over 100 characters
#51: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1224:
+				  jiffies + msecs_to_jiffies_timeout(CONFIG_DRM_I915_PREEMPT_TIMEOUT));

total: 0 errors, 1 warnings, 0 checks, 87 lines checked
fb14188d4b6e drm/i915: Add a label for config DRM_I915_SPIN_REQUEST

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-03 16:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 13:58 [PATCH 01/15] drm/i915: Make the semaphore saturation mask global Chris Wilson
2019-06-03 13:58 ` [PATCH 02/15] drm: Flush output polling on shutdown Chris Wilson
2019-06-04 12:43   ` Imre Deak
2019-06-03 13:58 ` [PATCH 03/15] drm/i915/selftests: Flush partial-tiling object once Chris Wilson
2019-06-03 13:58 ` [PATCH 04/15] drm/i915: Use unchecked writes for setting up the fences Chris Wilson
2019-06-03 13:59 ` [PATCH 05/15] drm/i915: Use unchecked unccore writes to flush the GTT Chris Wilson
2019-06-03 13:59 ` [PATCH 06/15] drm/i915: Report an earlier wedged event when suspending the engines Chris Wilson
2019-06-03 13:59 ` [PATCH 07/15] drm/i915: Move object close under its own lock Chris Wilson
2019-06-05 11:54   ` Matthew Auld
2019-06-03 13:59 ` [PATCH 08/15] drm/i915: Keep contexts pinned until after the next kernel context switch Chris Wilson
2019-06-03 13:59 ` [PATCH 09/15] drm/i915: Stop retiring along engine Chris Wilson
2019-06-03 13:59 ` [PATCH 10/15] drm/i915: Replace engine->timeline with a plain list Chris Wilson
2019-06-03 13:59 ` [PATCH 11/15] drm/i915: Flush the execution-callbacks on retiring Chris Wilson
2019-06-03 13:59 ` [PATCH 12/15] drm/i915/execlists: Preempt-to-busy Chris Wilson
2019-06-03 13:59 ` [PATCH 13/15] drm/i915/execlists: Minimalistic timeslicing Chris Wilson
2019-06-03 13:59 ` [PATCH 14/15] drm/i915/execlists: Force preemption Chris Wilson
2019-06-03 13:59 ` [PATCH 15/15] drm/i915: Add a label for config DRM_I915_SPIN_REQUEST Chris Wilson
2019-06-03 16:56 ` Patchwork [this message]
2019-06-03 17:02 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/15] drm/i915: Make the semaphore saturation mask global Patchwork
2019-06-03 17:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-04  8:07 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603165618.25580.57782@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox