public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: rename header test build commands to avoid conflicts
Date: Wed, 5 Jun 2019 15:35:39 +0200	[thread overview]
Message-ID: <20190605133539.GA29435@ravnborg.org> (raw)
In-Reply-To: <20190605132137.11818-1-jani.nikula@intel.com>

Hi Jani.

On Wed, Jun 05, 2019 at 04:21:37PM +0300, Jani Nikula wrote:
> We have a local hack to test if headers are self-contained, while
> upstreaming a proper generic solution in kbuild [1]. Now that both have
> found themselves in linux-next, the identical cmd_header_test build
> commands conflict, leading to errors such as:
> 
> >> drivers/gpu/drm/i915/header_test_intel_audio.c:1:10: fatal error:
> >> drivers/gpu/drm/i915/intel_audio.h: No such file or directory
>     #include "drivers/gpu/drm/i915/intel_audio.h"
> 	     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Rename the i915 local build command until the proper kbuild solution
> finds its way to Linus' master and gets backported to our tree, and we
> can finally switch over.
You could also ihave switched over now, and accpet that this only would be used
in -next for a few months.

Then at least you did not have to rememebr to change it again.

Any way works for me, just a suggestion.

	Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-05 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 13:21 [PATCH] drm/i915: rename header test build commands to avoid conflicts Jani Nikula
2019-06-05 13:35 ` Sam Ravnborg [this message]
2019-06-05 14:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06  3:04 ` [PATCH] " yamada.masahiro
2019-06-06  7:24   ` Jani Nikula
2019-06-06  7:32     ` yamada.masahiro
2019-06-06  8:00       ` Jani Nikula
2019-06-06 12:03         ` Masahiro Yamada
2019-06-06 12:16           ` Jani Nikula
2019-06-07  1:50 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605133539.GA29435@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox