✗ Fi.CI.CHECKPATCH: warning for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl (rev2)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl (rev2)
Date: Wed, 05 Jun 2019 14:12:15 -0000	[thread overview]
Message-ID: <20190605141215.10844.35268@emeril.freedesktop.org> (raw)
In-Reply-To: <20190529093038.27911-1-daniel.vetter@ffwll.ch>

== Series Details ==

Series: drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl (rev2)
URL   : https://patchwork.freedesktop.org/series/61299/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b69c7ced5090 drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ea487835e887 ("drm: Enforce unlocked ioctl operation for kms driver ioctls")'
#14: 
commit ea487835e8876abf7ad909636e308c801a2bcda6

-:24: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ed8b67040965 ("drm: convert drm_ioctl to unlocked_ioctl")'
#24: 
commit ed8b67040965e4fe695db333d5914e18ea5f146f

-:42: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8f4ff2b06afc ("drm: do not sleep on vblank while holding a mutex")'
#42: 
commit 8f4ff2b06afcd6f151868474a432c603057eaf56

-:52: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fdd5b877e9eb ("drm: Enforce BKL-less ioctls for modern drivers")'
#52: 
commit fdd5b877e9ebc2029e1373b4a3cd057329a9ab7a

-:231: WARNING:LONG_LINE: line over 100 characters
#231: FILE: drivers/gpu/drm/drm_ioctl.c:650:
+	DRM_IOCTL_DEF(DRM_IOCTL_PRIME_HANDLE_TO_FD, drm_prime_handle_to_fd_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),

-:231: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#231: FILE: drivers/gpu/drm/drm_ioctl.c:650:
+	DRM_IOCTL_DEF(DRM_IOCTL_PRIME_HANDLE_TO_FD, drm_prime_handle_to_fd_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
 	                                                                                  ^

-:232: WARNING:LONG_LINE: line over 100 characters
#232: FILE: drivers/gpu/drm/drm_ioctl.c:651:
+	DRM_IOCTL_DEF(DRM_IOCTL_PRIME_FD_TO_HANDLE, drm_prime_fd_to_handle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),

-:232: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#232: FILE: drivers/gpu/drm/drm_ioctl.c:651:
+	DRM_IOCTL_DEF(DRM_IOCTL_PRIME_FD_TO_HANDLE, drm_prime_fd_to_handle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
 	                                                                                  ^

-:335: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 4 errors, 3 warnings, 2 checks, 240 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx