public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev4)
Date: Wed, 05 Jun 2019 15:19:47 -0000	[thread overview]
Message-ID: <20190605151947.10845.68000@emeril.freedesktop.org> (raw)
In-Reply-To: <20190605133852.4493-1-lionel.g.landwerlin@intel.com>

== Series Details ==

Series: drm/i915: Vulkan performance query support (rev4)
URL   : https://patchwork.freedesktop.org/series/60916/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
abfe9e305ec9 drm/i915/perf: introduce a versioning of the i915-perf uapi
32203e3c3c4c drm/i915/perf: allow for CS OA configs to be created lazily
-:124: CHECK:SPACING: No space is necessary after a cast
#124: FILE: drivers/gpu/drm/i915/i915_perf.c:395:
+					(u32) MI_LOAD_REGISTER_IMM_MAX_REGS);

total: 0 errors, 0 warnings, 1 checks, 311 lines checked
3aef0b772b8a drm/i915: introduce a mechanism to extend execbuf2
-:126: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#126: FILE: include/uapi/drm/i915_drm.h:1170:
+#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_EXT<<1))
                                                   ^

total: 0 errors, 0 warnings, 1 checks, 103 lines checked
bfa3bc4cccc0 drm/i915: add syncobj timeline support
-:341: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#341: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2488:
+			 * The chain's ownership is transfered to the

-:365: ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2512:
+        [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$

-:365: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2512:
+        [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$

total: 1 errors, 2 warnings, 0 checks, 511 lines checked
151ed539e4ba drm/i915: add a new perf configuration execbuf parameter
-:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
#44: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1206:
 
+

-:170: ERROR:CODE_INDENT: code indent should use tabs where possible
#170: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2620:
+        [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$

-:170: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2620:
+        [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$

total: 1 errors, 1 warnings, 1 checks, 416 lines checked
ccd1cbb63c8e drm/i915/perf: allow holding preemption on filtered ctx
-:140: WARNING:BRACES: braces {} are not necessary for single statement blocks
#140: FILE: drivers/gpu/drm/i915/i915_perf.c:2727:
+	if (IS_HASWELL(dev_priv) && specific_ctx && !props->hold_preemption) {
 		privileged_op = false;
+	}

total: 0 errors, 1 warnings, 0 checks, 165 lines checked
ce2af5b1a9ca drm/i915: add support for perf configuration queries

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-05 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 13:38 [PATCH v4 0/7] drm/i915: Vulkan performance query support Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 1/7] drm/i915/perf: introduce a versioning of the i915-perf uapi Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 2/7] drm/i915/perf: allow for CS OA configs to be created lazily Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 3/7] drm/i915: introduce a mechanism to extend execbuf2 Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 4/7] drm/i915: add syncobj timeline support Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 5/7] drm/i915: add a new perf configuration execbuf parameter Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 6/7] drm/i915/perf: allow holding preemption on filtered ctx Lionel Landwerlin
2019-06-05 13:38 ` [PATCH v4 7/7] drm/i915: add support for perf configuration queries Lionel Landwerlin
2019-06-05 15:19 ` Patchwork [this message]
2019-06-05 15:24 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Vulkan performance query support (rev4) Patchwork
2019-06-05 15:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-07  4:23 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605151947.10845.68000@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox