From: Patchwork <patchwork@emeril.freedesktop.org>
To: Aditya Swarup <aditya.swarup@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Enable SSC for ICL using panel_use_ssc
Date: Wed, 05 Jun 2019 22:48:52 -0000 [thread overview]
Message-ID: <20190605224852.10842.96456@emeril.freedesktop.org> (raw)
In-Reply-To: <20190605215733.10227-1-aditya.swarup@intel.com>
== Series Details ==
Series: drm/i915/icl: Enable SSC for ICL using panel_use_ssc
URL : https://patchwork.freedesktop.org/series/61692/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2bbb59c67ab3 drm/i915/icl: Enable SSC for ICL using panel_use_ssc
-:44: WARNING:BRACES: braces {} are not necessary for single statement blocks
#44: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:2530:
+ if (intel_panel_use_ssc(dev_priv)) {
+ cfgcr0 |= DPLL_CFGCR0_SSC_ENABLE_ICL;
+ }
-:59: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#59: FILE: drivers/gpu/drm/i915/intel_drv.h:1505:
}
+static inline bool
-:65: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#65: FILE: drivers/gpu/drm/i915/intel_drv.h:1511:
+ return dev_priv->vbt.lvds_use_ssc
+ && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
total: 0 errors, 1 warnings, 2 checks, 38 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-05 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 21:57 [PATCH] drm/i915/icl: Enable SSC for ICL using panel_use_ssc Aditya Swarup
2019-06-05 22:48 ` Patchwork [this message]
2019-06-05 23:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06 7:08 ` [PATCH] " Jani Nikula
2019-06-07 21:53 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605224852.10842.96456@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=aditya.swarup@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox