public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Harish Chegondi <harish.chegondi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [RFC] drm: Do not call drm_probe_ddc() when connector force isn't specified
Date: Thu,  6 Jun 2019 00:38:00 -0700	[thread overview]
Message-ID: <20190606073800.64781-1-harish.chegondi@intel.com> (raw)

This would allow the EDID override to be handled correctly in
drm_do_get_edid() for cases where EDID data is missing or corrupt.

All drm_probe_ddc() does is call drm_do_probe_ddc_edid( , , , 1)
which probes the display by reading 1 byte of EDID data via I2C.
This patch removes the call to drm_probe_ddc() from drm_get_edid()
but drm_get_edid() calls drm_do_get_edid() which first handles
the EDID override case and then calls
drm_do_probe_ddc_edid( , , ,EDID_LENGTH) via function pointer
argument get_edid_block. So, the display device is still being
probed by reading EDID_LENGTH bytes of EDID data via I2C.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=107583
---
 drivers/gpu/drm/drm_edid.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index d87f574feeca..41c420706532 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1724,9 +1724,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
 	if (connector->force == DRM_FORCE_OFF)
 		return NULL;
 
-	if (connector->force == DRM_FORCE_UNSPECIFIED && !drm_probe_ddc(adapter))
-		return NULL;
-
 	edid = drm_do_get_edid(connector, drm_do_probe_ddc_edid, adapter);
 	if (edid)
 		drm_get_displayid(connector, edid);
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-06-06  7:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  7:38 Harish Chegondi [this message]
2019-06-06  8:47 ` ✓ Fi.CI.BAT: success for drm: Do not call drm_probe_ddc() when connector force isn't specified Patchwork
2019-06-06 11:22 ` [RFC] " Jani Nikula
2019-06-06 11:40 ` Daniel Vetter
2019-06-06 11:56   ` Jani Nikula
2019-06-06 21:38     ` Harish Chegondi
2019-06-07  7:37       ` Jani Nikula
2019-06-07  8:23     ` Daniel Vetter
2019-06-08 13:17 ` ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606073800.64781-1-harish.chegondi@intel.com \
    --to=harish.chegondi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox