public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Shyam Saini <shyam.saini@amarulasolutions.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for include: linux: Regularise the use of FIELD_SIZEOF macro
Date: Thu, 13 Jun 2019 00:31:53 -0000	[thread overview]
Message-ID: <20190613003153.21001.53014@emeril.freedesktop.org> (raw)
In-Reply-To: <20190611193836.2772-1-shyam.saini@amarulasolutions.com>

== Series Details ==

Series: include: linux: Regularise the use of FIELD_SIZEOF macro
URL   : https://patchwork.freedesktop.org/series/61982/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9c1c7908df88 include: linux: Regularise the use of FIELD_SIZEOF macro
-:116: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#116: FILE: fs/befs/linuxvfs.c:442:
+				FIELD_SIZEOF(struct befs_inode_info,
 					i_data.symlink),

-:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#155: FILE: fs/freevxfs/vxfs_super.c:333:
+			FIELD_SIZEOF(struct vxfs_inode_info,
 				vii_immed.vi_immed),

-:168: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#168: FILE: fs/orangefs/super.c:650:
+					FIELD_SIZEOF(struct orangefs_inode_s,
 						link_target),

-:181: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#181: FILE: fs/ufs/super.c:1473:
+				FIELD_SIZEOF(struct ufs_inode_info,
 					i_u1.i_symlink),

-:232: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#232: FILE: include/linux/stddef.h:29:
+#define FIELD_SIZEOF(t, f) (sizeof(((t *)0)->f))

-:232: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#232: FILE: include/linux/stddef.h:29:
+#define FIELD_SIZEOF(t, f) (sizeof(((t *)0)->f))

-:372: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#372: FILE: tools/testing/selftests/bpf/bpf_util.h:69:
+#define FIELD_SIZEOF(t, f) (sizeof(((t *)0)->f))

-:372: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#372: FILE: tools/testing/selftests/bpf/bpf_util.h:69:
+#define FIELD_SIZEOF(t, f) (sizeof(((t *)0)->f))

total: 0 errors, 0 warnings, 8 checks, 268 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-13  0:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 19:38 [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro Shyam Saini
2019-06-11 20:46 ` Kees Cook
2019-06-11 21:05   ` Shyam Saini
2019-06-11 20:48 ` Andrew Morton
2019-06-11 21:00   ` Andreas Dilger
2019-06-11 21:09     ` Andrew Morton
2019-06-11 21:27       ` Shyam Saini
2019-06-11 21:28       ` Andreas Dilger
2019-06-29 14:25     ` Alexey Dobriyan
2019-06-29 16:45       ` Joe Perches
2019-07-02 16:33         ` Kees Cook
2019-06-12  0:05 ` Alexei Starovoitov
2019-06-13  0:31 ` Patchwork [this message]
2019-06-13  2:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-14 14:36 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613003153.21001.53014@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shyam.saini@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox