From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Lee, Shawn C" <shawn.c.lee@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Cooper Chiou <cooper.chiou@intel.com>,
intel-gfx@lists.freedesktop.org, Lee@freedesktop.org
Subject: Re: [PATCH] drm/i915: Refine eDP aux backlight enable sequence.
Date: Thu, 13 Jun 2019 12:19:43 +0300 [thread overview]
Message-ID: <20190613091943.GU5942@intel.com> (raw)
In-Reply-To: <1560404842-13583-1-git-send-email-shawn.c.lee@intel.com>
On Wed, Jun 12, 2019 at 10:47:22PM -0700, Lee, Shawn C wrote:
> Modify aux backlight enable sequence just like what we
> did for genernal eDP panel.
> 1. Setup PWM freq and brightness level before enable display backlight.
> 2. Add T8 (valid data to backlight enable) delay.
If we respect the on_delay shouldn't we then respect the off_delay too?
In which case I suggest two patches:
1. swaap the enable vs. set_brightness order
2. add the on/off delays
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
> index 7ded95a334db..c112e0b930de 100644
> --- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
> @@ -216,8 +216,12 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
> }
> }
>
> - set_aux_backlight_enable(intel_dp, true);
> intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
> +
> + wait_remaining_ms_from_jiffies(intel_dp->last_power_on,
> + intel_dp->backlight_on_delay);
> +
> + set_aux_backlight_enable(intel_dp, true);
> }
>
> static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-13 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 5:47 [PATCH] drm/i915: Refine eDP aux backlight enable sequence Lee, Shawn C
2019-06-13 5:41 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-13 6:01 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-13 9:19 ` Ville Syrjälä [this message]
2019-06-13 13:16 ` [PATCH] " Jani Nikula
2019-06-14 1:42 ` Lee, Shawn C
2019-06-14 7:58 ` Jani Nikula
2019-06-14 17:07 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613091943.GU5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Lee@freedesktop.org \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shawn.c.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox