public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC][PATCH 0/2] drm: PATH prop for all connectors?
Date: Thu, 13 Jun 2019 22:42:08 +0200	[thread overview]
Message-ID: <20190613204208.GR23020@phenom.ffwll.local> (raw)
In-Reply-To: <20190613184335.7970-1-ville.syrjala@linux.intel.com>

On Thu, Jun 13, 2019 at 09:43:33PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Here's a possible apporoach for providing userspace with
> some stable connector identifiers. Combine with the bus
> name of the GPU and you should have some kind of real
> physical path description. Unfortunately the ship has
> sailed for MST connectors because userspace is already
> parsing the property and expects to find certain things
> there. So if we want stable names for those we'd probably
> have introduce another PATH prop (PHYS_PATH?).
> 
> I suppose one alternative would to make the connector 
> type_id stable. Currently that is being populated by drm 
> core and it's just a global counter. Not sure how badly
> things would turn out if we'd allow each driver to set
> that. It could result in conflicting xrandr connector
> names between different GPUs which I suppose would
> confuse existing userspace?

I think the only reason this global id stuff exists is because with
original xrandr, that stuff was global. And then it got copypasted
forever.

Would need to do a bunch of reviewing, but I'd expect we'll get away with
just making all these allocators per-device.
-Daniel

> 
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> Cc: Ilia Mirkin <imirkin@alum.mit.edu>
> 
> Ville Syrjälä (2):
>   drm: Improve PATH prop docs
>   drm/i915: Populate PATH prop for every connector
> 
>  drivers/gpu/drm/drm_connector.c        | 13 ++++++++--
>  drivers/gpu/drm/i915/icl_dsi.c         |  3 +++
>  drivers/gpu/drm/i915/intel_connector.c | 20 +++++++++++++++
>  drivers/gpu/drm/i915/intel_connector.h |  3 +++
>  drivers/gpu/drm/i915/intel_crt.c       |  2 ++
>  drivers/gpu/drm/i915/intel_dp.c        |  6 ++++-
>  drivers/gpu/drm/i915/intel_dp_mst.c    |  3 +--
>  drivers/gpu/drm/i915/intel_dvo.c       |  3 +++
>  drivers/gpu/drm/i915/intel_hdmi.c      |  4 +++
>  drivers/gpu/drm/i915/intel_lvds.c      |  2 ++
>  drivers/gpu/drm/i915/intel_sdvo.c      | 35 ++++++++++++++++++--------
>  drivers/gpu/drm/i915/intel_tv.c        |  2 ++
>  drivers/gpu/drm/i915/vlv_dsi.c         |  3 +++
>  13 files changed, 83 insertions(+), 16 deletions(-)
> 
> -- 
> 2.21.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-06-13 20:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 18:43 [RFC][PATCH 0/2] drm: PATH prop for all connectors? Ville Syrjala
2019-06-13 18:43 ` [RFC][PATCH 1/2] drm: Improve PATH prop docs Ville Syrjala
2019-06-27  7:36   ` Pekka Paalanen
2019-06-13 18:43 ` [RFC][PATCH 2/2] drm/i915: Populate PATH prop for every connector Ville Syrjala
2019-06-27  7:37   ` Pekka Paalanen
2019-06-13 18:50 ` ✗ Fi.CI.CHECKPATCH: warning for drm: PATH prop for all connectors? Patchwork
2019-06-13 20:42 ` Daniel Vetter [this message]
2019-06-27  7:35   ` [RFC][PATCH 0/2] " Pekka Paalanen
2019-06-27  7:44     ` Michel Dänzer
2019-06-14 11:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-15  8:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-10 22:43 ` [Intel-gfx] [RFC][PATCH 0/2] " Lyude Paul
2019-07-11  7:20   ` Daniel Vetter
     [not found]   ` <20190711102923.3d219640@eldfell.localdomain>
2019-07-16 14:59     ` [Intel-gfx] " Li, Sun peng (Leo)
2019-08-01  9:51       ` Pekka Paalanen
2019-08-01 18:24         ` Li, Sun peng (Leo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613204208.GR23020@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox