✗ Fi.CI.CHECKPATCH: warning for Implicit dev_priv removal and GT compartmentalization (rev10)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Implicit dev_priv removal and GT compartmentalization (rev10)
Date: Tue, 18 Jun 2019 14:06:26 -0000	[thread overview]
Message-ID: <20190618140626.30452.99013@emeril.freedesktop.org> (raw)
In-Reply-To: <20190618130345.6135-1-tvrtko.ursulin@linux.intel.com>

== Series Details ==

Series: Implicit dev_priv removal and GT compartmentalization (rev10)
URL   : https://patchwork.freedesktop.org/series/62046/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bca713c077ed drm/i915: Convert intel_vgt_(de)balloon to uncore
a874245a108d drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
This is a first step towards cleaning up the separation between i915 and gt.

-:17: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

-:22: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#22: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:1:
+/*

-:23: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#23: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 4 warnings, 0 checks, 99 lines checked
445c006c72e5 drm/i915: Move intel_gt initialization to a separate file
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

-:35: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#35: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:1:
+/*

-:36: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#36: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:2:
+ * SPDX-License-Identifier: MIT

-:56: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#56: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:1:
+/*

-:57: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#57: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 85 lines checked
40e8600548d8 drm/i915: Store some backpointers in struct intel_gt
1a8d86d8278a drm/i915: Move intel_gt_pm_init under intel_gt_init_early
3fd2fa4739ae drm/i915: Make i915_check_and_clear_faults take intel_gt
4b48b3caffe7 drm/i915: Convert i915_gem_init_swizzling to intel_gt
149907ceada4 drm/i915: Use intel_uncore_rmw in intel_gt_init_swizzling
6ba27abeff0a drm/i915: Convert init_unused_rings to intel_gt
4308960f1ea1 drm/i915: Convert gt workarounds to intel_gt
61ee04e3470b drm/i915: Store backpointer to intel_gt in the engine
12a8ade3b29f drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt
b5ca0f164fd4 drm/i915: Convert i915_ppgtt_init_hw to intel_gt
d7c5ee7bc99b drm/i915: Consolidate some open coded mmio rmw
5902c532fa2a drm/i915: Convert i915_gem_init_hw to intel_gt
-:128: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#128: FILE: drivers/gpu/drm/i915/i915_gem.c:1311:
+	BUG_ON(!i915->kernel_context);

total: 0 errors, 1 warnings, 0 checks, 116 lines checked
1e57741313db drm/i915: Move intel_engines_resume into common init
80ee8d9d5c4b drm/i915: Stop using I915_READ/WRITE in intel_wopcm_init_hw
17c76b182987 drm/i915: Compartmentalize i915_ggtt_probe_hw
0d15597ed258 drm/i915: Compartmentalize i915_ggtt_init_hw
e0833e28d33d drm/i915: Make ggtt invalidation work on ggtt
055d3fb75c5f drm/i915: Store intel_gt backpointer in vm
24acd770b767 drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings
07c9d8087a95 drm/i915: Convert i915_gem_flush_ggtt_writes to intel_gt
-:114: WARNING:MEMORY_BARRIER: memory barrier without comment
#114: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:178:
+	wmb();

total: 0 errors, 1 warnings, 0 checks, 173 lines checked
c8c04454a823 drm/i915: Move i915_gem_chipset_flush to intel_gt
-:108: WARNING:MEMORY_BARRIER: memory barrier without comment
#108: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:197:
+	wmb();

total: 0 errors, 1 warnings, 0 checks, 268 lines checked
f372a23f4974 drm/i915: Compartmentalize timeline_init/park/fini
8636df9732b4 drm/i915: Compartmentalize i915_ggtt_cleanup_hw
e489e26404f5 drm/i915: Compartmentalize i915_gem_init_ggtt
a41381ff2d46 drm/i915: Store ggtt pointer in intel_gt
07be710c7ea7 drm/i915: Compartmentalize ring buffer creation
6a9e93ca185f drm/i915: Save trip via top-level i915 in a few more places
815d5cee0e92 drm/i915: Make timelines gt centric
5fdd0de3e9c2 drm/i915: Rename i915_timeline to intel_timeline and move under gt
-:342: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#342: 
rename from drivers/gpu/drm/i915/i915_timeline.c

-:682: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#682: FILE: drivers/gpu/drm/i915/gt/intel_timeline.h:1:
+/*

total: 0 errors, 2 warnings, 0 checks, 1326 lines checked
a3880faf715d drm/i915: Eliminate dual personality of i915_scratch_offset

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx