From: Patchwork <patchwork@emeril.freedesktop.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical
Date: Tue, 18 Jun 2019 16:37:19 -0000 [thread overview]
Message-ID: <20190618163719.30455.90833@emeril.freedesktop.org> (raw)
In-Reply-To: <20190618161731.15607-1-mika.kuoppala@linux.intel.com>
== Series Details ==
Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical
URL : https://patchwork.freedesktop.org/series/62324/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
224a6de52ba2 drm/i915/gtt: pde entry encoding is identical
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd' - possible side-effects?
#55: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:734:
+#define init_pd(vm, pd, to) { \
+ GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd)); \
+ fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+ memset_p((pd)->entry, (to), 512); \
}
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#55: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:734:
+#define init_pd(vm, pd, to) { \
+ GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd)); \
+ fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+ memset_p((pd)->entry, (to), 512); \
}
total: 0 errors, 0 warnings, 2 checks, 235 lines checked
4f46c24d9757 drm/i915/gtt: Tear down setup and cleanup macros for page dma
3fc849b75c9d drm/i915/gtt: Setup phys pages for 3lvl pdps
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-18 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 16:17 [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical Mika Kuoppala
2019-06-18 16:17 ` [PATCH 2/3] drm/i915/gtt: Tear down setup and cleanup macros for page dma Mika Kuoppala
2019-06-18 16:17 ` [PATCH 3/3] drm/i915/gtt: Setup phys pages for 3lvl pdps Mika Kuoppala
2019-06-18 16:37 ` Chris Wilson
2019-06-18 16:32 ` [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical Chris Wilson
2019-06-18 16:37 ` Patchwork [this message]
2019-06-18 16:39 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] " Patchwork
2019-06-18 16:53 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-19 8:40 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-07-04 15:44 [PATCH 1/3] " Mika Kuoppala
2019-07-04 17:31 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618163719.30455.90833@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox