From: Patchwork <patchwork@emeril.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
Date: Tue, 18 Jun 2019 18:33:44 -0000 [thread overview]
Message-ID: <20190618183344.30454.74255@emeril.freedesktop.org> (raw)
In-Reply-To: <20190614180734.13350-1-matthew.d.roper@intel.com>
== Series Details ==
Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
URL : https://patchwork.freedesktop.org/series/62131/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d46fd4652551 drm/i915/ehl: Allow combo PHY A to drive a third external display
-:67: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_A].child"
#67: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:265:
+ bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
-:68: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_D].child"
#68: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:266:
+ bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
total: 0 errors, 0 warnings, 2 checks, 65 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-18 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
2019-06-14 18:32 ` Ville Syrjälä
2019-06-17 23:48 ` [PATCH v2] " Matt Roper
2019-06-18 16:08 ` Ville Syrjälä
2019-06-18 17:30 ` Matt Roper
2019-06-18 17:39 ` Ville Syrjälä
2019-06-18 17:51 ` [PATCH v3] " Matt Roper
2019-06-15 5:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-17 10:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-18 0:10 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2) Patchwork
2019-06-18 0:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-18 14:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-18 18:33 ` Patchwork [this message]
2019-06-18 18:49 ` ✓ Fi.CI.BAT: success for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3) Patchwork
2019-06-19 13:28 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-19 18:31 ` Matt Roper
2019-06-19 19:04 ` Saarinen, Jani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618183344.30454.74255@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox