public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/i915: Fix memleak in runtime wakeref tracking
Date: Thu, 27 Jun 2019 18:06:57 +0300	[thread overview]
Message-ID: <20190627150657.GA13359@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <87h88b3wfu.fsf@gaia.fi.intel.com>

On Thu, Jun 27, 2019 at 06:00:21PM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > Quoting Mika Kuoppala (2019-06-27 15:44:38)
> >> If we untrack wakerefs, the actual count may reach zero.
> >> However the krealloced owners array is still there and
> >> needs to be taken care of. Free the owners unconditionally
> >> to fix the leak.
> >
> > That is true.
> >
> >> Fixes: dbf99c1f8c7e ("drm/i915: Force printing wakeref tacking during pm_cleanup")
> >
> > However, the bug is mine
> > Fixes: bd780f37a361 ("drm/i915: Track all held rpm wakerefs")
> 
> Indeed. Apologies Imre!
> 
> I personally know the reviewer of the original patch
> and will have a discussion.

Good catch, I've been staring at the kmemleak logs J-P provided, but
couldn't see how it can happen. 

> -Mika
> 
> >
> >> Reported-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> >> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Imre Deak <imre.deak@intel.com>
> >> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-27 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 14:44 [PATCH 1/1] drm/i915: Fix memleak in runtime wakeref tracking Mika Kuoppala
2019-06-27 14:53 ` Chris Wilson
2019-06-27 15:00   ` Mika Kuoppala
2019-06-27 15:06     ` Imre Deak [this message]
2019-06-27 15:04   ` [PATCH] " Mika Kuoppala
2019-06-28  7:38 ` ✗ Fi.CI.BAT: failure for series starting with drm/i915: Fix memleak in runtime wakeref tracking (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627150657.GA13359@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox