Re: [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake

From: kbuild test robot <lkp@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake
Date: Sat, 29 Jun 2019 12:04:40 +0800	[thread overview]
Message-ID: <201906291254.9gqWFAqZ%lkp@intel.com> (raw)
In-Reply-To: <20190629003709.14513-1-anusha.srivatsa@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3940 bytes --]

Hi Anusha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190625]
[cannot apply to v5.2-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anusha-Srivatsa/drm-i915-guc-Define-GuC-firmware-version-for-Comet-Lake/20190629-110106
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/intel_guc_fw.c: In function 'guc_fw_select':
>> drivers/gpu//drm/i915/intel_guc_fw.c:104:13: error: implicit declaration of function 'IS_COMETLAKE'; did you mean 'IS_COFFEELAKE'? [-Werror=implicit-function-declaration]
     } else if (IS_COMETLAKE(i915)) {
                ^~~~~~~~~~~~
                IS_COFFEELAKE
>> drivers/gpu//drm/i915/intel_guc_fw.c:105:7: error: implicit declaration of function 'REVID'; did you mean 'READ'? [-Werror=implicit-function-declaration]
      if (REVID(dev_priv) == 5) {
          ^~~~~
          READ
>> drivers/gpu//drm/i915/intel_guc_fw.c:105:13: error: 'dev_priv' undeclared (first use in this function); did you mean 'dev_crit'?
      if (REVID(dev_priv) == 5) {
                ^~~~~~~~
                dev_crit
   drivers/gpu//drm/i915/intel_guc_fw.c:105:13: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +104 drivers/gpu//drm/i915/intel_guc_fw.c

    81	
    82	static void guc_fw_select(struct intel_uc_fw *guc_fw)
    83	{
    84		struct intel_guc *guc = container_of(guc_fw, struct intel_guc, fw);
    85		struct drm_i915_private *i915 = guc_to_i915(guc);
    86	
    87		GEM_BUG_ON(guc_fw->type != INTEL_UC_FW_TYPE_GUC);
    88	
    89		if (!HAS_GUC(i915))
    90			return;
    91	
    92		if (i915_modparams.guc_firmware_path) {
    93			guc_fw->path = i915_modparams.guc_firmware_path;
    94			guc_fw->major_ver_wanted = 0;
    95			guc_fw->minor_ver_wanted = 0;
    96		} else if (IS_ICELAKE(i915)) {
    97			guc_fw->path = ICL_GUC_FIRMWARE_PATH;
    98			guc_fw->major_ver_wanted = ICL_GUC_FW_MAJOR;
    99			guc_fw->minor_ver_wanted = ICL_GUC_FW_MINOR;
   100		} else if (IS_GEMINILAKE(i915)) {
   101			guc_fw->path = GLK_GUC_FIRMWARE_PATH;
   102			guc_fw->major_ver_wanted = GLK_GUC_FW_MAJOR;
   103			guc_fw->minor_ver_wanted = GLK_GUC_FW_MINOR;
 > 104		} else if (IS_COMETLAKE(i915)) {
 > 105			if (REVID(dev_priv) == 5) {
   106				guc_fw->path = CML_GUC_FIRMWARE_PATH;
   107				guc_fw->major_ver_wanted = CML_GUC_FW_MAJOR;
   108				guc_fw->minor_ver_wanted = CML_GUC_FW_MINOR;
   109			} else {
   110				guc_fw->path = KBL_GUC_FIRMWARE_PATH;
   111				guc_fw->major_ver_wanted = KBL_GUC_FW_MAJOR;
   112				guc_fw->minor_ver_wanted = KBL_GUC_FW_MINOR;
   113			}
   114		} else if (IS_KABYLAKE(i915) || IS_COFFEELAKE(i915)) {
   115			guc_fw->path = KBL_GUC_FIRMWARE_PATH;
   116			guc_fw->major_ver_wanted = KBL_GUC_FW_MAJOR;
   117			guc_fw->minor_ver_wanted = KBL_GUC_FW_MINOR;
   118		} else if (IS_BROXTON(i915)) {
   119			guc_fw->path = BXT_GUC_FIRMWARE_PATH;
   120			guc_fw->major_ver_wanted = BXT_GUC_FW_MAJOR;
   121			guc_fw->minor_ver_wanted = BXT_GUC_FW_MINOR;
   122		} else if (IS_SKYLAKE(i915)) {
   123			guc_fw->path = SKL_GUC_FIRMWARE_PATH;
   124			guc_fw->major_ver_wanted = SKL_GUC_FW_MAJOR;
   125			guc_fw->minor_ver_wanted = SKL_GUC_FW_MINOR;
   126		}
   127	}
   128	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68949 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx