From: Sam Ravnborg <sam@ravnborg.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
intel-gfx@lists.freedesktop.org,
Thierry Reding <treding@nvidia.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: make drm_panel.h self-contained
Date: Sun, 30 Jun 2019 10:16:02 +0200 [thread overview]
Message-ID: <20190630081602.GB5081@ravnborg.org> (raw)
In-Reply-To: <20190627110103.7539-1-jani.nikula@intel.com>
Hi Jani.
On Thu, Jun 27, 2019 at 02:01:03PM +0300, Jani Nikula wrote:
> Fix build warning if drm_panel.h is built with CONFIG_OF=n or
> CONFIG_DRM_PANEL=n and included without the prerequisite err.h:
>
> ./include/drm/drm_panel.h: In function ‘of_drm_find_panel’:
> ./include/drm/drm_panel.h:203:9: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration]
> return ERR_PTR(-ENODEV);
> ^~~~~~~
> ./include/drm/drm_panel.h:203:9: error: returning ‘int’ from a function with return type ‘struct drm_panel *’ makes pointer from integer without a cast [-Werror=int-conversion]
> return ERR_PTR(-ENODEV);
> ^~~~~~~~~~~~~~~~
>
> Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL")
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
When we start to deploy headers-test I expect us to find many more of
this class of issues.
But lets get them fixed so we do not see sporadic build errors due
to missing dependencies in the header files.
I assume you will commit the fix.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-30 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 11:01 [PATCH] drm/panel: make drm_panel.h self-contained Jani Nikula
2019-06-27 12:31 ` Thierry Reding
2019-06-27 16:18 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-06-30 8:16 ` Sam Ravnborg [this message]
2019-08-01 9:09 ` [PATCH] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190630081602.GB5081@ravnborg.org \
--to=sam@ravnborg.org \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox