From: Patchwork <patchwork@emeril.freedesktop.org>
To: Oleg Vasilev <oleg.vasilev@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm: report dp downstream port type as a subconnector property
Date: Mon, 01 Jul 2019 09:37:50 -0000 [thread overview]
Message-ID: <20190701093750.12147.35076@emeril.freedesktop.org> (raw)
In-Reply-To: <20190701080022.9415-1-oleg.vasilev@intel.com>
== Series Details ==
Series: series starting with [1/2] drm: report dp downstream port type as a subconnector property
URL : https://patchwork.freedesktop.org/series/63026/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e4c5221b85cd drm: report dp downstream port type as a subconnector property
-:31: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#31: FILE: drivers/gpu/drm/drm_connector.c:796:
+ { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I, TV-out and DP */
-:54: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Wireless>
#54: FILE: drivers/gpu/drm/drm_connector.c:828:
+ { DRM_MODE_SUBCONNECTOR_Wireless, "Wireless" }, /* DP */
-:55: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native>
#55: FILE: drivers/gpu/drm/drm_connector.c:829:
+ { DRM_MODE_SUBCONNECTOR_Native, "Native" }, /* DP */
-:202: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Automatic>
#202: FILE: include/uapi/drm/drm_mode.h:335:
+ DRM_MODE_SUBCONNECTOR_Automatic = 0, /* DVI-I, TV */
-:208: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Composite>
#208: FILE: include/uapi/drm/drm_mode.h:341:
+ DRM_MODE_SUBCONNECTOR_Composite = 5, /* TV */
-:210: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Component>
#210: FILE: include/uapi/drm/drm_mode.h:343:
+ DRM_MODE_SUBCONNECTOR_Component = 8, /* TV */
total: 0 errors, 0 warnings, 6 checks, 164 lines checked
eafc29b760a7 drm/i915: utilize subconnector property for DP
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5535:
+
-:27: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#27: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5546:
+ enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown;
-:36: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#36: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5639:
+ subconnector = drm_dp_downstream_subconnector_type(
-:41: WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'connector->dev->mode_config.dp_subconnector_property'
#41: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5644:
+ connector->dev->
+ mode_config.dp_subconnector_property,
total: 0 errors, 1 warnings, 3 checks, 39 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-01 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 8:00 [PATCH 1/2] drm: report dp downstream port type as a subconnector property Oleg Vasilev
2019-07-01 8:00 ` [PATCH 2/2] drm/i915: utilize subconnector property for DP Oleg Vasilev
2019-07-01 9:37 ` Patchwork [this message]
2019-07-01 9:40 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm: report dp downstream port type as a subconnector property Patchwork
2019-07-01 10:07 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-02 11:15 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-02 12:36 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2019-07-02 13:38 ` Emil Velikov
2019-07-03 8:19 ` Vasilev, Oleg
2019-07-03 13:35 ` [Intel-gfx] " Emil Velikov
[not found] ` <20190715112408.20114-1-oleg.vasilev@intel.com>
2019-07-15 11:23 ` [PATCH v2 4/6] drm/i915: utilize subconnector property for DP Oleg Vasilev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701093750.12147.35076@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oleg.vasilev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox