public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [RFC 7/7] drm/i915: Allow vdsc functions to be called without encoder.
Date: Tue,  2 Jul 2019 21:42:05 +0200	[thread overview]
Message-ID: <20190702194205.13366-8-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20190702194205.13366-1-maarten.lankhorst@linux.intel.com>

This can be useful when calling the vdsc enable functions
directly without encoder.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vdsc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index 419a77723894..f009524ab735 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -897,7 +897,7 @@ void intel_dsc_enable(struct intel_encoder *encoder,
 		      const struct intel_crtc_state *crtc_state)
 {
 	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
-	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
 	enum pipe pipe = crtc->pipe;
 	i915_reg_t dss_ctl1_reg, dss_ctl2_reg;
 	u32 dss_ctl1_val = 0;
@@ -910,9 +910,11 @@ void intel_dsc_enable(struct intel_encoder *encoder,
 	intel_display_power_get(dev_priv,
 				intel_dsc_power_domain(crtc_state));
 
-	intel_configure_pps_for_dsc_encoder(encoder, crtc_state);
+	if (encoder) {
+		intel_configure_pps_for_dsc_encoder(encoder, crtc_state);
 
-	intel_dp_write_dsc_pps_sdp(encoder, crtc_state);
+		intel_dp_write_dsc_pps_sdp(encoder, crtc_state);
+	}
 
 	if (crtc_state->cpu_transcoder == TRANSCODER_EDP) {
 		dss_ctl1_reg = DSS_CTL1;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-07-02 19:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 19:41 [RFC 0/7] Bigjoiner atomic preparations Maarten Lankhorst
2019-07-02 19:41 ` [RFC 1/7] drm/i915: Prepare to split crtc state in uapi and hw state Maarten Lankhorst
2019-07-02 19:42 ` [RFC 2/7] drm/i915: Handle a few more cases for hw/sw split Maarten Lankhorst
2019-07-02 19:42 ` [RFC 3/7] drm/i915: Complete sw/hw split Maarten Lankhorst
2019-07-02 19:42 ` [RFC 4/7] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid() Maarten Lankhorst
2019-07-03  0:13   ` Manasi Navare
2019-07-02 19:42 ` [RFC 5/7] drm/i915/dp: Validate modes that can only be handled in a bigjoiner configuration Maarten Lankhorst
2019-07-02 19:42 ` [RFC 6/7] drm/i915: Try to make bigjoiner work in atomic check Maarten Lankhorst
2019-07-03  0:32   ` Manasi Navare
2019-07-03  8:02     ` Maarten Lankhorst
2019-07-02 19:42 ` Maarten Lankhorst [this message]
2019-07-10 22:35   ` [RFC 7/7] drm/i915: Allow vdsc functions to be called without encoder Manasi Navare
2019-07-30  9:08     ` Maarten Lankhorst
2019-08-21 19:54       ` Manasi Navare
2019-07-02 21:30 ` ✗ Fi.CI.CHECKPATCH: warning for Bigjoiner atomic preparations Patchwork
2019-07-02 21:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-02 21:59 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-03 22:04 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702194205.13366-8-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox