From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gt: Drop the duplicate workaround
Date: Wed, 10 Jul 2019 17:40:38 -0700 [thread overview]
Message-ID: <20190711004038.GC9599@intel.com> (raw)
In-Reply-To: <20190710200428.3275-1-chris@chris-wilson.co.uk>
On Wed, Jul 10, 2019 at 09:04:28PM +0100, Chris Wilson wrote:
> The workarounds was revived in the backmerge that was meant to fix it!
>
> Fixes: 88c90e800675 ("Merge drm/drm-next into drm-intel-next-queued")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Duh! Sorry about that and thanks for dropping the fixup from drm-rerere.
I was hopping the backmerge + push would fail when applying the fixup
so I would remove it. Instead it went through my scripts silently to the
end... :(
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index f6fd6905ee6f..9e069286d3ce 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -531,12 +531,6 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
> {
> struct drm_i915_private *i915 = engine->i915;
>
> - /* WaDisableBankHangMode:icl */
> - wa_write(wal,
> - GEN8_L3CNTLREG,
> - intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
> - GEN8_ERRDETBCTRL);
> -
> /* WaDisableBankHangMode:icl */
> wa_write(wal,
> GEN8_L3CNTLREG,
> --
> 2.22.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-11 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 20:04 [PATCH] drm/i915/gt: Drop the duplicate workaround Chris Wilson
2019-07-11 0:40 ` Rodrigo Vivi [this message]
2019-07-11 12:18 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-07-11 20:50 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711004038.GC9599@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox