From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY
Date: Thu, 18 Jul 2019 14:14:45 -0700 [thread overview]
Message-ID: <20190718211445.GC30177@intel.com> (raw)
In-Reply-To: <156348349623.6999.4776587555290794879@skylake-alporthouse-com>
On Thu, Jul 18, 2019 at 09:58:16PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-07-18 21:49:12)
> > +void intel_display_power_resume_early(struct drm_i915_private *i915)
> > +{
> > + if (!HAS_DISPLAY(i915))
> > + return;
> > +
> > + if (INTEL_GEN(i915) >= 11 || IS_GEN9_LP(i915)) {
> > + gen9_sanitize_dc_state(i915);
>
> Are you sure that whatever state you are resuming from agrees with your
> notion of !display? The sanitize routines are supposed to be about
> cleaning up after third parties who don't play by the same rules.
I don't expect any function setting any kind of dc states when we don't
have display. Besides the path that sets DC_STATE_EN is and neeeds to
be sanitized is also covered by this patch and this shouldn't happen.
Or am I missing something else?
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-18 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 20:49 [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY Rodrigo Vivi
2019-07-18 20:58 ` Chris Wilson
2019-07-18 21:14 ` Rodrigo Vivi [this message]
2019-07-18 21:25 ` Chris Wilson
2019-07-18 21:38 ` Rodrigo Vivi
2019-08-06 12:02 ` Jani Nikula
2019-08-06 17:01 ` Rodrigo Vivi
2019-07-18 21:23 ` ✗ Fi.CI.SPARSE: warning for drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev5) Patchwork
2019-07-18 21:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-19 5:19 ` ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-07-18 20:47 [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY Rodrigo Vivi
2019-05-23 23:17 Rodrigo Vivi
2019-05-28 12:47 ` Jani Nikula
2019-07-10 23:29 ` Souza, Jose
2019-05-20 4:56 Rodrigo Vivi
2019-05-20 21:35 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718211445.GC30177@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox