public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Kumar Valsan, Prathap" <prathap.kumar.valsan@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Separate pinning of pages from i915_vma_insert()
Date: Mon, 5 Aug 2019 16:44:36 -0400	[thread overview]
Message-ID: <20190805204436.GB3842@intel.com> (raw)
In-Reply-To: <156477784355.6598.13904246729423995531@skylake-alporthouse-com>

On Fri, Aug 02, 2019 at 09:30:43PM +0100, Chris Wilson wrote:
> Quoting Prathap Kumar Valsan (2019-08-02 21:41:11)
> > Currently i915_vma_insert() is responsible for allocating drm mm node
> > and also allocating or gathering physical pages. Move the latter to a
> > separate function for better readability.
> 
> Close but if you look at the mutex patches, you'll see why it has to be
> before.
> -Chris

Looked at the Mutex patches. With async get_pages and async bind, pinning
and set pages are already separated out from i915_vma_insert(). So this
patch may not be needed.

Thanks,
Prathap
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-05 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 20:41 [PATCH] drm/i915: Separate pinning of pages from i915_vma_insert() Prathap Kumar Valsan
2019-08-02 20:30 ` Chris Wilson
2019-08-05 20:44   ` Kumar Valsan, Prathap [this message]
2019-08-02 20:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-04 13:22 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805204436.GB3842@intel.com \
    --to=prathap.kumar.valsan@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox