public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Send a hotplug when edid changes (rev4)
Date: Tue, 06 Aug 2019 14:01:32 -0000	[thread overview]
Message-ID: <20190806140132.1118.31417@emeril.freedesktop.org> (raw)
In-Reply-To: <20190806125551.25761-1-stanislav.lisovskiy@intel.com>

== Series Details ==

Series: Send a hotplug when edid changes (rev4)
URL   : https://patchwork.freedesktop.org/series/62816/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
36f82de41a75 drm: Add helper to compare edids.
-:32: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid1"
#32: FILE: drivers/gpu/drm/drm_edid.c:1375:
+	bool edid1_present = edid1 != NULL;

-:33: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid2"
#33: FILE: drivers/gpu/drm/drm_edid.c:1376:
+	bool edid2_present = edid2 != NULL;

-:39: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#39: FILE: drivers/gpu/drm/drm_edid.c:1382:
+	if (edid1) {
+

-:54: CHECK:LINE_SPACING: Please don't use multiple blank lines
#54: FILE: drivers/gpu/drm/drm_edid.c:1397:
+
+

total: 0 errors, 0 warnings, 4 checks, 54 lines checked
489410ace4ab drm: Introduce change counter to drm_connector
-:42: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#42: FILE: drivers/gpu/drm/drm_probe_helper.c:779:
+	uint64_t old_epoch_counter;

-:69: WARNING:BRACES: braces {} are not necessary for single statement blocks
#69: FILE: drivers/gpu/drm/drm_probe_helper.c:811:
+		if (old_status != connector->status) {
 			changed = true;
+		}

-:102: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#102: FILE: include/drm/drm_connector.h:1286:
+	uint64_t epoch_counter;

total: 0 errors, 1 warnings, 2 checks, 69 lines checked
96448743d614 drm/i915: Send hotplug event if edid had changed.
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8: 
to calling layer using drm_connector->change_counter(proposed by Daniel Vetter).

-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5328:
+		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Edid was changed! Updating blob property.\n",
+		    connector->base.id, connector->name);

-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2535:
+		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Edid was changed! Updating blob property.\n",
+		    connector->base.id, connector->name);

-:134: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#134: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:302:
+		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s(change counter %llu)\n",
 		      connector->base.base.id,

total: 0 errors, 1 warnings, 3 checks, 102 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-08-06 14:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 12:55 [PATCH v3 0/3] Send a hotplug when edid changes Stanislav Lisovskiy
2019-08-06 12:55 ` [PATCH v3 1/3] drm: Add helper to compare edids Stanislav Lisovskiy
2019-08-06 12:55 ` [PATCH v3 2/3] drm: Introduce change counter to drm_connector Stanislav Lisovskiy
2019-08-06 12:55 ` [PATCH v3 3/3] drm/i915: Send hotplug event if edid had changed Stanislav Lisovskiy
2019-08-06 13:51 ` [PATCH v3 0/3] Send a hotplug when edid changes Daniel Vetter
2019-08-06 14:06   ` Lisovskiy, Stanislav
2019-08-06 17:43     ` Daniel Vetter
2019-08-07  7:43       ` Lisovskiy, Stanislav
2019-08-07 21:07         ` Daniel Vetter
2019-08-19  7:23           ` Lisovskiy, Stanislav
2019-08-19  7:35             ` Peres, Martin
2019-08-19  9:05               ` Lisovskiy, Stanislav
2019-09-03  9:17                 ` Lisovskiy, Stanislav
2019-09-03  9:40                   ` Daniel Vetter
2019-09-03 11:49                     ` Lisovskiy, Stanislav
2019-09-03 14:21                       ` Lisovskiy, Stanislav
2019-09-03 15:49                       ` Daniel Vetter
2019-09-04  8:36                         ` Lisovskiy, Stanislav
2019-09-04  9:23                           ` Daniel Vetter
2019-09-04 10:14                             ` Lisovskiy, Stanislav
2019-08-06 14:01 ` Patchwork [this message]
2019-08-06 14:21 ` ✓ Fi.CI.BAT: success for Send a hotplug when edid changes (rev4) Patchwork
2019-08-07  1:43 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190806140132.1118.31417@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox