public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] dma-buf: add reservation_object_fences helper
Date: Fri, 09 Aug 2019 13:07:16 -0000	[thread overview]
Message-ID: <20190809130716.30609.30246@emeril.freedesktop.org> (raw)
In-Reply-To: <20190807135312.1730-1-christian.koenig@amd.com>

== Series Details ==

Series: series starting with [1/4] dma-buf: add reservation_object_fences helper
URL   : https://patchwork.freedesktop.org/series/64955/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6ff342a1513c dma-buf: add reservation_object_fences helper
-:25: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#25: FILE: drivers/dma-buf/dma-buf.c:202:
+	unsigned shared_count;

-:191: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#191: FILE: drivers/dma-buf/reservation.c:508:
+	unsigned shared_count;

-:238: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#238: FILE: drivers/dma-buf/reservation.c:599:
+	unsigned shared_count;

-:427: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'

total: 0 errors, 4 warnings, 0 checks, 381 lines checked
aaef55f6b88d drm/i915: use new reservation_object_fences helper
-:61: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'

total: 0 errors, 1 warnings, 0 checks, 43 lines checked
5dd5e3f55895 dma-buf: further relax reservation_object_add_shared_fence
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
Other cores don't busy wait any more and we removed the last user of checking

-:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'

total: 0 errors, 2 warnings, 0 checks, 31 lines checked
ee9de2492811 dma-buf: nuke reservation_object seq number
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
The only remaining use for this is to protect against setting a new exclusive

-:57: WARNING:MEMORY_BARRIER: memory barrier without comment
#57: FILE: drivers/dma-buf/reservation.c:279:
+		smp_store_mb(old->shared_count, 0);

-:112: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'

total: 0 errors, 3 warnings, 0 checks, 80 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-08-09 13:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 13:53 [PATCH 1/4] dma-buf: add reservation_object_fences helper Christian König
2019-08-07 13:53 ` [PATCH 2/4] drm/i915: use new " Christian König
2019-08-07 16:08   ` Chris Wilson
2019-08-07 13:53 ` [PATCH 3/4] dma-buf: further relax reservation_object_add_shared_fence Christian König
2019-08-07 16:10   ` Chris Wilson
2019-08-07 13:53 ` [PATCH 4/4] dma-buf: nuke reservation_object seq number Christian König
2019-08-07 14:17   ` Chris Wilson
2019-08-10 10:51     ` Christian König
2019-08-14 15:39       ` Daniel Vetter
2019-08-14 16:42         ` Chris Wilson
2019-08-14 17:06           ` Chris Wilson
2019-08-14 17:22             ` Chris Wilson
2019-08-14 17:38               ` Chris Wilson
2019-08-14 17:48                 ` Chris Wilson
2019-08-14 17:58                   ` Koenig, Christian
2019-08-14 18:52                     ` Chris Wilson
2019-08-14 17:06           ` Daniel Vetter
2019-08-14 17:20             ` Chris Wilson
2019-08-14 17:48               ` Daniel Vetter
2019-08-07 16:07 ` [PATCH 1/4] dma-buf: add reservation_object_fences helper Chris Wilson
2019-08-09 13:07 ` Patchwork [this message]
2019-08-09 13:31 ` ✓ Fi.CI.BAT: success for series starting with [1/4] " Patchwork
2019-08-10  6:31 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809130716.30609.30246@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox