From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
dri-devel@lists.freedesktop.org, linux-kbuild@vger.kernel.org,
Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
David Airlie <airlied@linux.ie>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH 0/5] kbuild: allow big modules to sub-divide Makefiles
Date: Sat, 10 Aug 2019 08:46:11 +0200 [thread overview]
Message-ID: <20190810064611.GC13020@ravnborg.org> (raw)
In-Reply-To: <20190806063923.1266-1-yamada.masahiro@socionext.com>
Hi Masahiro
On Tue, Aug 06, 2019 at 03:39:18PM +0900, Masahiro Yamada wrote:
>
> Recently, Jani Nikula requests a better build system support
> for drivers spanning multiple directories.
> (better kbuild support for drivers spanning multiple directories?)
>
> I implemented it, so please take a look at it.
>
> Note:
> The single targets do not work correctly.
>
> The single targets have never worked correctly:
It works in most cases, but now always.
I dunno how much it is used.
Myself I almost always do make /drivers/foo/bar/
>
> [1] For instance, "make drivers/foo/bar/baz.o" will descend into
> drivers/foo/bar/Makefile, which may not necessarily specify
> the build rule of baz.o
>
> It is possible for drivers/foo/Makefile having
> obj-$(CONFIG_BAZ) += bar/baz.o
>
> [2] subdir-ccflags-y does not work.
>
> The single targets directly descend into the directory of
> that file resides.
>
> It missed subdir-ccflags-y if it is specifies in parent
> Makefiles.
>
> Perhaps, I will have to manage correct implementation of single targets.
The day that kbuild has a separate step to read all Makefiles
and then without using recursive make can build the kernel we can have
this fixed.
Until then we can accpet it as is - as fixing this may not be simple.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-08-10 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 6:39 [PATCH 0/5] kbuild: allow big modules to sub-divide Makefiles Masahiro Yamada
2019-08-06 6:39 ` [PATCH 1/5] kbuild: treat an object as multi-used when $(foo-) is set Masahiro Yamada
2019-08-19 14:53 ` Masahiro Yamada
2019-08-06 6:39 ` [PATCH 2/5] kbuild: clean up modname calculation Masahiro Yamada
2019-08-06 6:39 ` [PATCH 3/5] kbuild: rename cmd_ar_builtin to cmd_ar_no_sym Masahiro Yamada
2019-08-06 6:39 ` [PATCH 4/5] kbuild: support composite objects spanning across multiple Makefiles Masahiro Yamada
2019-08-06 6:39 ` [PATCH 5/5] drm: i915: hierachize Makefiles Masahiro Yamada
2019-08-10 6:46 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810064611.GC13020@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rodrigo.vivi@intel.com \
--cc=yamada.masahiro@socionext.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox