From: kbuild test robot <lkp@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock
Date: Mon, 12 Aug 2019 23:29:38 +0800 [thread overview]
Message-ID: <201908122352.syNF32Y6%lkp@intel.com> (raw)
In-Reply-To: <20190812111321.30574-1-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 5031 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v5.3-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-execlists-Lift-process_csb-out-of-the-irq-off-spinlock/20190812-211057
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_in':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:541:2: error: implicit declaration of function 'intel_context_inflight_inc'; did you mean 'intel_context_inflight_count'? [-Werror=implicit-function-declaration]
intel_context_inflight_inc(rq->hw_context);
^~~~~~~~~~~~~~~~~~~~~~~~~~
intel_context_inflight_count
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_out':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:551:2: error: implicit declaration of function 'intel_context_inflight_dec'; did you mean 'intel_context_inflight'? [-Werror=implicit-function-declaration]
intel_context_inflight_dec(rq->hw_context);
^~~~~~~~~~~~~~~~~~~~~~~~~~
intel_context_inflight
cc1: some warnings being treated as errors
vim +541 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
77f0d0e925e8a0 drivers/gpu/drm/i915/i915_guc_submission.c Chris Wilson 2017-05-17 534
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 535 static struct i915_request *schedule_in(struct i915_request *rq, int idx)
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 536 {
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 537 trace_i915_request_in(rq, idx);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 538
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 539 if (!rq->hw_context->inflight)
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 540 rq->hw_context->inflight = rq->engine;
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 @541 intel_context_inflight_inc(rq->hw_context);
c7302f204490f3 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Chris Wilson 2019-08-08 542 intel_gt_pm_get(rq->engine->gt);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 543
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 544 return i915_request_get(rq);
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 545 }
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 546
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 547 static void schedule_out(struct i915_request *rq)
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 548 {
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 549 trace_i915_request_out(rq);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 550
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 @551 intel_context_inflight_dec(rq->hw_context);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 552 if (!intel_context_inflight_count(rq->hw_context))
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 553 rq->hw_context->inflight = NULL;
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 554
c7302f204490f3 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Chris Wilson 2019-08-08 555 intel_gt_pm_put(rq->engine->gt);
22b7a426bbe1eb drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2019-06-20 556 i915_request_put(rq);
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 557 }
2a694feb93556e drivers/gpu/drm/i915/intel_guc_submission.c Chris Wilson 2018-04-03 558
:::::: The code at line 541 was first introduced by commit
:::::: 22b7a426bbe1ebe1520f92da4cd1617d1e1b5fc4 drm/i915/execlists: Preempt-to-busy
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28082 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-12 15:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 9:10 [PATCH 1/8] drm/i915/execlists: Avoid sync calls during park Chris Wilson
2019-08-12 9:10 ` [PATCH 2/8] drm/i915/selftests: Prevent the timeslice expiring during suppression tests Chris Wilson
2019-08-12 9:39 ` Mika Kuoppala
2019-08-12 9:58 ` Chris Wilson
2019-08-12 10:28 ` Mika Kuoppala
2019-08-12 9:10 ` [PATCH 3/8] drm/i915/guc: Use a local cancel_port_requests Chris Wilson
2019-08-12 9:10 ` [PATCH 4/8] drm/i915: Push the wakeref->count deferral to the backend Chris Wilson
2019-08-12 9:10 ` [PATCH 5/8] drm/i915/gt: Save/restore interrupts around breadcrumb disable Chris Wilson
2019-08-12 9:10 ` [PATCH 6/8] drm/i915/guc: Keep the engine awake until the tasklet is idle Chris Wilson
2019-08-12 10:44 ` Chris Wilson
2019-08-12 20:38 ` Daniele Ceraolo Spurio
2019-08-12 20:42 ` Chris Wilson
2019-08-12 9:10 ` [PATCH 7/8] drm/i915/gt: Use the local engine wakeref when checking RING registers Chris Wilson
2019-08-12 12:16 ` Mika Kuoppala
2019-08-12 9:10 ` [PATCH 8/8] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock Chris Wilson
2019-08-12 11:13 ` [PATCH] " Chris Wilson
2019-08-12 15:29 ` kbuild test robot [this message]
2019-08-12 9:27 ` [PATCH 1/8] drm/i915/execlists: Avoid sync calls during park Mika Kuoppala
2019-08-12 9:33 ` Chris Wilson
2019-08-12 9:40 ` Mika Kuoppala
2019-08-12 12:54 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915/execlists: Avoid sync calls during park (rev2) Patchwork
2019-08-12 12:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-08-12 13:22 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-12 19:21 ` ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 9:24 [PATCH 1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock Chris Wilson
2019-08-16 11:49 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908122352.syNF32Y6%lkp@intel.com \
--to=lkp@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox