From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Fix HW readout for crtc_clock in HDMI mode
Date: Mon, 19 Aug 2019 19:14:37 +0300 [thread overview]
Message-ID: <20190819161437.GX5942@intel.com> (raw)
In-Reply-To: <20190808162547.7009-1-imre.deak@intel.com>
On Thu, Aug 08, 2019 at 07:25:47PM +0300, Imre Deak wrote:
> The conversion during HDMI HW readout from port_clock to crtc_clock was
> missed when HDMI 10bpc support was added, so fix that.
>
> v2:
> - Unscrew the non-HDMI case.
>
> Fixes: cd9e11a8bf25 ("drm/i915/icl: Add 10-bit support for hdmi")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109593
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_display_types.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index aa5b2440513c..7c73d1f974fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -1467,8 +1467,8 @@ static void ddi_dotclock_get(struct intel_crtc_state *pipe_config)
> else if (intel_crtc_has_dp_encoder(pipe_config))
> dotclock = intel_dotclock_calculate(pipe_config->port_clock,
> &pipe_config->dp_m_n);
> - else if (pipe_config->has_hdmi_sink && pipe_config->pipe_bpp == 36)
> - dotclock = pipe_config->port_clock * 2 / 3;
> + else if (pipe_config->has_hdmi_sink && pipe_config->pipe_bpp > 24)
> + dotclock = pipe_config->port_clock * 24 / pipe_config->pipe_bpp;
> else
> dotclock = pipe_config->port_clock;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a88ec9aa9ca0..21cb7ee34d45 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -866,7 +866,7 @@ struct intel_crtc_state {
>
> /*
> * Frequence the dpll for the port should run at. Differs from the
> - * adjusted dotclock e.g. for DP or 12bpc hdmi mode. This is also
> + * adjusted dotclock e.g. for DP or 10/12bpc hdmi mode. This is also
> * already multiplied by pixel_multiplier.
> */
> int port_clock;
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-19 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:37 [PATCH] drm/i915: Fix HW readout for crtc_clock in HDMI mode Imre Deak
2019-08-08 14:27 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-08-08 14:48 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-08-08 16:25 ` [PATCH v2] " Imre Deak
2019-08-19 16:14 ` Ville Syrjälä [this message]
2019-08-08 19:29 ` ✓ Fi.CI.BAT: success for drm/i915: Fix HW readout for crtc_clock in HDMI mode (rev2) Patchwork
2019-08-09 6:55 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-08-09 8:47 ` Imre Deak
2019-08-20 13:15 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819161437.GX5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox