From: Fernando Pacheco <fernando.pacheco@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/3] drm/i915/uc: Fini hw even if GuC is not running
Date: Tue, 27 Aug 2019 17:45:58 -0700 [thread overview]
Message-ID: <20190828004558.11903-4-fernando.pacheco@intel.com> (raw)
In-Reply-To: <20190828004558.11903-1-fernando.pacheco@intel.com>
We should not be skipping uc_fini_hw on finding GuC
is no longer running. There is plenty of hw and internal
state that can be cleaned up without having to communicate
with GuC.
v2: better to check if fw is available (Michal)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110943
Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index b2eb340ce87e..ad5b928fe36a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -535,7 +535,7 @@ void intel_uc_fini_hw(struct intel_uc *uc)
{
struct intel_guc *guc = &uc->guc;
- if (!intel_guc_is_running(guc))
+ if (!intel_uc_fw_is_available(&guc->fw))
return;
if (intel_guc_is_submission_enabled(guc))
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-28 0:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 0:45 [PATCH 0/3] Add/modify checks within intel_uc_fini_hw Fernando Pacheco
2019-08-28 0:45 ` [PATCH 1/3] drm/i915/uc: Extract common code from GuC stop/disable comm Fernando Pacheco
2019-08-28 20:47 ` Daniele Ceraolo Spurio
2019-08-28 22:09 ` Daniele Ceraolo Spurio
2019-08-28 0:45 ` [PATCH 2/3] drm/i915/uc: Disable GuC submission only if currently enabled Fernando Pacheco
2019-09-09 13:29 ` Janusz Krzysztofik
2019-08-28 0:45 ` Fernando Pacheco [this message]
2019-08-28 10:29 ` ✓ Fi.CI.BAT: success for Add/modify checks within intel_uc_fini_hw Patchwork
2019-08-29 10:26 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828004558.11903-4-fernando.pacheco@intel.com \
--to=fernando.pacheco@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).