Re: [PATCH v11 06/10] drm/i915/perf: implement active wait for noa configurations

From: kbuild test robot <lkp@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH v11 06/10] drm/i915/perf: implement active wait for noa configurations
Date: Thu, 29 Aug 2019 03:34:14 +0800	[thread overview]
Message-ID: <201908290308.WB5m8lf9%lkp@intel.com> (raw)
In-Reply-To: <20190828143327.7965-7-lionel.g.landwerlin@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi Lionel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[cannot apply to v5.3-rc6 next-20190828]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-Vulkan-performance-query-support/20190829-020841
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_debugfs.c: In function 'i915_perf_noa_delay_set':
>> drivers/gpu/drm/i915/i915_debugfs.c:3588:18: warning: left shift count >= width of type [-Wshift-count-overflow]
     if (val > ((1ul << 32) - 1) * RUNTIME_INFO(i915)->cs_timestamp_frequency_khz)
                     ^~

vim +3588 drivers/gpu/drm/i915/i915_debugfs.c

  3575	
  3576	DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
  3577				i915_wedged_get, i915_wedged_set,
  3578				"%llu\n");
  3579	
  3580	static int
  3581	i915_perf_noa_delay_set(void *data, u64 val)
  3582	{
  3583		struct drm_i915_private *i915 = data;
  3584	
  3585		/* This would lead to infinite waits as we're doing timestamp
  3586		 * difference on the CS with only 32bits.
  3587		 */
> 3588		if (val > ((1ul << 32) - 1) * RUNTIME_INFO(i915)->cs_timestamp_frequency_khz)
  3589			return -EINVAL;
  3590	
  3591		atomic64_set(&i915->perf.noa_programming_delay, val);
  3592		return 0;
  3593	}
  3594	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28074 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx