public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Heinrich Fink <heinrich.fink@daqri.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm: Add high-precision time to vblank trace event
Date: Mon, 02 Sep 2019 14:40:46 -0000	[thread overview]
Message-ID: <20190902144046.16950.69596@emeril.freedesktop.org> (raw)
In-Reply-To: <20190809153639.14193-1-heinrich.fink@daqri.com>

== Series Details ==

Series: drm: Add high-precision time to vblank trace event
URL   : https://patchwork.freedesktop.org/series/66132/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
764d6d8263bc drm: Add high-precision time to vblank trace event
-:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#50: FILE: drivers/gpu/drm/drm_trace.h:31:
+	    TP_printk("crtc=%d, seq=%u, time=%lld, high-prec=%s",
+			__entry->crtc, __entry->seq, __entry->time,

-:65: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#65: FILE: drivers/gpu/drm/drm_vblank.c:1735:
+	trace_drm_vblank_event(pipe, seq, now,
+			dev->driver->get_vblank_timestamp != NULL);

-:65: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "dev->driver->get_vblank_timestamp"
#65: FILE: drivers/gpu/drm/drm_vblank.c:1735:
+			dev->driver->get_vblank_timestamp != NULL);

total: 0 errors, 0 warnings, 3 checks, 36 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-09-02 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190809153639.14193-1-heinrich.fink@daqri.com>
2019-08-14 17:15 ` [PATCH] drm: Add high-precision time to vblank trace event Daniel Vetter
2019-09-02 14:24   ` Heinrich Fink
2019-09-02 14:24     ` [PATCH v2] " Heinrich Fink
2019-09-03  7:46       ` Daniel Vetter
2019-09-03  9:19         ` Heinrich Fink
2019-09-03  9:52           ` Daniel Vetter
2019-09-21  8:33             ` Heinrich Fink
2019-09-23 12:05               ` Daniel Vetter
2019-09-23 14:09                 ` Heinrich Fink
2019-09-02 14:40 ` Patchwork [this message]
2019-09-02 15:04 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-02 16:52 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902144046.16950.69596@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=heinrich.fink@daqri.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox