From: Ramalingam C <ramalingam.c@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/i915: Create dumb buffer from LMEM
Date: Mon, 23 Sep 2019 15:31:00 +0530 [thread overview]
Message-ID: <20190923100100.GA21342@intel.com> (raw)
In-Reply-To: <156892350961.1196.1328671197355986285@skylake-alporthouse-com>
On 2019-09-19 at 21:05:09 +0100, Chris Wilson wrote:
> Quoting Ramalingam C (2019-09-19 19:04:33)
> > When LMEM is supported, dumb buffer preferred to be created from LMEM.
> >
> > This is developed on top of v3 LMEM series
> > https://patchwork.freedesktop.org/series/56683/.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > cc: Matthew Auld <matthew.auld@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++----
> > 1 file changed, 14 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index e458507b1558..c0decbd020ce 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -161,7 +161,7 @@ static int
> > i915_gem_create(struct drm_file *file,
> > struct drm_i915_private *dev_priv,
> > u64 *size_p,
> > - u32 *handle_p)
> > + u32 *handle_p, enum intel_region_id mem_region)
>
> General pattern is to keep outparams last.
Modified the order of the parameters. Thanks Chris!
-Ram
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-09-23 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 18:04 [PATCH] drm/i915: Create dumb buffer from LMEM Ramalingam C
2019-09-19 20:05 ` Chris Wilson
2019-09-23 10:01 ` Ramalingam C [this message]
2019-09-19 20:49 ` ✗ Fi.CI.BUILD: failure for " Patchwork
2019-09-21 15:33 ` [PATCH] " kbuild test robot
2019-09-21 15:42 ` kbuild test robot
2019-09-23 9:59 ` [PATCH v2] " Ramalingam C
2019-09-23 12:56 ` ✗ Fi.CI.BUILD: failure for drm/i915: Create dumb buffer from LMEM (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923100100.GA21342@intel.com \
--to=ramalingam.c@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox