public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Jason Wang <jasowang@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev2)
Date: Mon, 23 Sep 2019 18:22:34 -0000	[thread overview]
Message-ID: <20190923182234.29099.42826@emeril.freedesktop.org> (raw)
In-Reply-To: <20190923130331.29324-1-jasowang@redhat.com>

== Series Details ==

Series: mdev based hardware virtio offloading support (rev2)
URL   : https://patchwork.freedesktop.org/series/66989/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d79d4220ecb7 mdev: class id support
39e2e5c7ea18 mdev: introduce device specific ops
-:317: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#317: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 411 lines checked
48d2885862d8 mdev: introduce virtio device and its device ops
-:51: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 172 lines checked
ada668d2b867 virtio: introduce a mdev based transport
-:55: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

-:95: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#95: FILE: drivers/vfio/mdev/virtio_mdev.c:36:
+	spinlock_t lock;

-:122: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#122: FILE: drivers/vfio/mdev/virtio_mdev.c:63:
+static void virtio_mdev_get(struct virtio_device *vdev, unsigned offset,

-:123: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#123: FILE: drivers/vfio/mdev/virtio_mdev.c:64:
+			    void *buf, unsigned len)

-:131: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#131: FILE: drivers/vfio/mdev/virtio_mdev.c:72:
+static void virtio_mdev_set(struct virtio_device *vdev, unsigned offset,

-:132: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#132: FILE: drivers/vfio/mdev/virtio_mdev.c:73:
+			    const void *buf, unsigned len)

-:199: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#199: FILE: drivers/vfio/mdev/virtio_mdev.c:140:
+virtio_mdev_setup_vq(struct virtio_device *vdev, unsigned index,

-:278: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#278: FILE: drivers/vfio/mdev/virtio_mdev.c:219:
+
+}

-:304: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#304: FILE: drivers/vfio/mdev/virtio_mdev.c:245:
+static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs,

-:438: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#438: FILE: drivers/vfio/mdev/virtio_mdev.c:379:
+
+}

total: 0 errors, 7 warnings, 3 checks, 437 lines checked
5aa1512e1678 vringh: fix copy direction of vringh_iov_push_kern()
6d4e2cf95a29 docs: sample driver to demonstrate how to implement virtio-mdev framework
-:38: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
#38: FILE: samples/Kconfig:134:
+config SAMPLE_VIRTIO_MDEV_NET

-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

-:146: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#146: FILE: samples/vfio-mdev/mvnet.c:84:
+	spinlock_t lock;

-:179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#179: FILE: samples/vfio-mdev/mvnet.c:117:
+	vringh_init_kern(&vq->vring, mvnet_features, MVNET_QUEUE_MAX,
+			false, 0, 0, 0);

-:284: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!addr"
#284: FILE: samples/vfio-mdev/mvnet.c:222:
+	if (addr == NULL)

-:287: CHECK:SPACING: No space is necessary after a cast
#287: FILE: samples/vfio-mdev/mvnet.c:225:
+		*dma_addr = (dma_addr_t) addr;

-:315: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*mvnet)...) over kzalloc(sizeof(struct mvnet_state)...)
#315: FILE: samples/vfio-mdev/mvnet.c:253:
+	mvnet = kzalloc(sizeof(struct mvnet_state), GFP_KERNEL);

-:316: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!mvnet"
#316: FILE: samples/vfio-mdev/mvnet.c:254:
+	if (mvnet == NULL)

-:370: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#370: FILE: samples/vfio-mdev/mvnet.c:308:
+sample_mvnet_dev_show(struct device *dev, struct device_attribute *attr,
+		     char *buf)

total: 0 errors, 2 warnings, 7 checks, 712 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-09-23 18:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23 13:03 [PATCH 0/6] mdev based hardware virtio offloading support Jason Wang
2019-09-23 13:03 ` [PATCH 1/6] mdev: class id support Jason Wang
2019-09-23 16:05   ` Alex Williamson
2019-09-24 10:11     ` Jason Wang
2019-09-23 20:58   ` Parav Pandit
2019-09-24 11:20     ` Jason Wang
2019-09-23 21:02   ` Parav Pandit
2019-09-24 11:23     ` Jason Wang
2019-09-23 13:03 ` [PATCH 2/6] mdev: introduce device specific ops Jason Wang
2019-09-23 15:20   ` kbuild test robot
2019-09-23 15:36     ` Michael S. Tsirkin
2019-09-24 11:23       ` Jason Wang
2019-09-23 22:59   ` Parav Pandit
2019-09-24 11:26     ` Jason Wang
2019-09-23 13:03 ` [PATCH 3/6] mdev: introduce virtio device and its device ops Jason Wang
2019-09-23 13:03 ` [PATCH 4/6] virtio: introduce a mdev based transport Jason Wang
2019-09-23 22:28   ` Parav Pandit
2019-09-24 11:30     ` Jason Wang
2019-09-23 13:03 ` [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern() Jason Wang
2019-09-23 15:45   ` Alex Williamson
2019-09-23 16:00     ` Michael S. Tsirkin
2019-09-24 14:04       ` Alex Williamson
2019-09-25 11:56         ` Jason Wang
2019-09-23 13:03 ` [PATCH 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-09-23 13:59 ` [PATCH 0/6] mdev based hardware virtio offloading support Michael S. Tsirkin
2019-09-23 18:22 ` Patchwork [this message]
2019-09-23 18:44 ` ✓ Fi.CI.BAT: success for mdev based hardware virtio offloading support (rev2) Patchwork
2019-09-24  6:07 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190923182234.29099.42826@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jasowang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox