From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Describe structure member in documentation
Date: Mon, 23 Sep 2019 21:28:08 +0300 [thread overview]
Message-ID: <20190923182808.GQ1208@intel.com> (raw)
In-Reply-To: <20190923164011.kv5dmlshcbygswdj@ldmartin-desk1>
On Mon, Sep 23, 2019 at 10:23:45AM -0700, Lucas De Marchi wrote:
> On Mon, Sep 23, 2019 at 03:56:40PM +0300, Anna Karas wrote:
> >Add description of wakeref member of intel_shared_dpll structure to
> >documentation.
> >
> >Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> >Signed-off-by: Anna Karas <anna.karas@intel.com>
> >---
> > drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >index 104cf6d42333..e35dd6b04443 100644
> >--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> >@@ -337,6 +337,11 @@ struct intel_shared_dpll {
> > * @info: platform specific info
> > */
> > const struct dpll_info *info;
> >+
> >+ /**
> >+ * @wakeref: A device-level runtime pm reference grabbed only if
> >+ * it is powered on.
> >+ */
>
> but this is only grabbed for DPLL4, on EHL.
>
> "In some platforms a device-level runtime pm reference may need to be
> grabbed to disable DC states while this DPLL is enabled" would be more
> appropriate IMO.
Or we could just remove the special case and have every pll grab some
power reference.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-09-23 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 12:56 [PATCH] drm/i915: Describe structure member in documentation Anna Karas
2019-09-23 17:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-23 17:23 ` [PATCH] " Lucas De Marchi
2019-09-23 18:28 ` Ville Syrjälä [this message]
2019-09-24 2:31 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-10-08 9:28 ` [PATCH] " Anna Karas
2019-10-08 10:37 ` ✓ Fi.CI.BAT: success for drm/i915: Describe structure member in documentation (rev2) Patchwork
2019-10-08 15:09 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923182808.GQ1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox