From: Patchwork <patchwork@emeril.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev8)
Date: Mon, 30 Sep 2019 23:04:13 -0000 [thread overview]
Message-ID: <20190930230413.32579.67154@emeril.freedesktop.org> (raw)
In-Reply-To: <20190930224707.14904-1-matthew.d.roper@intel.com>
== Series Details ==
Series: CRTC background color (rev8)
URL : https://patchwork.freedesktop.org/series/50834/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ce8779b97946 drm: Add CRTC background color property
-:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects?
#255: FILE: include/uapi/drm/drm_mode.h:1049:
+#define DRM_ARGB_COMP(c, shift, numbits) \
+ (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits)))
total: 0 errors, 0 warnings, 1 checks, 151 lines checked
fbe4bbbe8aec drm/i915/gen9+: Add support for pipe background color
52e2c82f7a75 drm/i915: Add background color hardware readout and state check
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+ if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+ pipe_config_mismatch(fastset, __stringify(name), \
+ "(expected 0x%016llx, found 0x%016llx)\n", \
+ current_config->name & mask, \
+ pipe_config->name & mask); \
+ ret = false; \
+ } \
+} while (0)
-:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+ if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+ pipe_config_mismatch(fastset, __stringify(name), \
+ "(expected 0x%016llx, found 0x%016llx)\n", \
+ current_config->name & mask, \
+ pipe_config->name & mask); \
+ ret = false; \
+ } \
+} while (0)
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+ if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+ pipe_config_mismatch(fastset, __stringify(name), \
+ "(expected 0x%016llx, found 0x%016llx)\n", \
+ current_config->name & mask, \
+ pipe_config->name & mask); \
+ ret = false; \
+ } \
+} while (0)
-:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mask' may be better as '(mask)' to avoid precedence issues
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+ if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+ pipe_config_mismatch(fastset, __stringify(name), \
+ "(expected 0x%016llx, found 0x%016llx)\n", \
+ current_config->name & mask, \
+ pipe_config->name & mask); \
+ ret = false; \
+ } \
+} while (0)
total: 0 errors, 0 warnings, 4 checks, 62 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-09-30 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 22:47 [PATCH v7 0/3] CRTC background color Matt Roper
2019-09-30 22:47 ` [PATCH v7 1/3] drm: Add CRTC background color property Matt Roper
2019-09-30 22:47 ` [PATCH v7 2/3] drm/i915/gen9+: Add support for pipe background color Matt Roper
2019-09-30 22:47 ` [PATCH v7 3/3] drm/i915: Add background color hardware readout and state check Matt Roper
2019-09-30 23:04 ` Patchwork [this message]
2019-09-30 23:13 ` [PATCH i-g-t] tests/kms_crtc_background_color: overhaul to match upstream ABI (v5.1) Matt Roper
2019-10-01 2:18 ` Martin Peres
2019-10-01 12:27 ` [igt-dev] " Ville Syrjälä
2019-10-09 15:43 ` Daniel Vetter
2019-09-30 23:50 ` ✓ Fi.CI.BAT: success for CRTC background color (rev8) Patchwork
2019-10-01 7:20 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-09 21:01 ` [PATCH v7 0/3] CRTC background color Daniele Castagna
2019-10-09 21:27 ` Matt Roper
2019-10-11 16:09 ` [Intel-gfx] " Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930230413.32579.67154@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox