public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
Date: Thu, 17 Oct 2019 06:24:22 -0000	[thread overview]
Message-ID: <20191017062422.14700.72781@emeril.freedesktop.org> (raw)
In-Reply-To: <20191017061106.22640-1-umesh.nerlige.ramappa@intel.com>

== Series Details ==

Series: series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
URL   : https://patchwork.freedesktop.org/series/68130/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2a67cb3ab9f8 drm/i915/perf: Add helper macros for comparing with whitelisted registers
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/i915_perf.c:3517:
+#define ADDR_IN_RANGE(addr, start, end) \
+	((addr) >= (start) && \
+	 (addr) <= (end))

-:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#24: FILE: drivers/gpu/drm/i915/i915_perf.c:3521:
+#define REG_IN_RANGE(addr, start, end) \
+	((addr) >= i915_mmio_reg_offset(start) && \
+	 (addr) <= i915_mmio_reg_offset(end))

total: 0 errors, 0 warnings, 2 checks, 98 lines checked
feaf3920fcd1 drm/i915/tgl: Add perf support on TGL
-:723: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#723: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 775 lines checked
e357e3e132ed drm/i915/perf: enable OAR context save/restore of performance counters
-:168: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "oa_config"
#168: FILE: drivers/gpu/drm/i915/i915_perf.c:2384:
+			err = gen12_configure_context_oar(ctx, oa_config != NULL);

total: 0 errors, 0 warnings, 1 checks, 141 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-17  6:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  6:11 [PATCH v2 1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers Umesh Nerlige Ramappa
2019-10-17  6:11 ` [PATCH v2 2/3] drm/i915/tgl: Add perf support on TGL Umesh Nerlige Ramappa
2019-10-17  6:11 ` [PATCH v2 3/3] drm/i915/perf: enable OAR context save/restore of performance counters Umesh Nerlige Ramappa
2019-10-17  6:30   ` Chris Wilson
2019-10-17  7:24     ` Umesh Nerlige Ramappa
2019-10-17  6:24 ` Patchwork [this message]
2019-10-17  6:26 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers Patchwork
2019-10-17  7:06 ` ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-10-17  7:20 [PATCH v2 1/3] " Umesh Nerlige Ramappa
2019-10-17  7:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] " Patchwork
2019-10-17 22:57 [PATCH v2 1/3] " Umesh Nerlige Ramappa
2019-10-18  1:04 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] " Patchwork
2019-10-18  0:50 [PATCH v2 1/3] " Umesh Nerlige Ramappa
2019-10-18  2:35 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017062422.14700.72781@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox